Conditional breakpoint only stops the first time

[rei-vilo]

Describe the bug

Conditional breakpoint only stops the first time.

Adding i%2 to line 8 only stops the first time when i=1, but not after when i=3 or 5.

To Reproduce

Same example as for #120 but with modified shown below.

Expected behavior

Debugger stops at 1, 3 and 5.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Version: 2.0.0 beta 4
• SAMD core 1.8.11

Additional context

• Modified LocalLibrary.cpp

#include "LocalLibrary.h"

// Code
void blinkLED(uint8_t pin, uint8_t times, uint16_t ms, bool level)
{
    for (uint8_t i = 0; i < times * 2; i++)
    {
        digitalWrite(pin, (level ^(i%2)) ? HIGH : LOW);
        delay(ms >> 1);
    }
}

[ubidefeo]

@rei-vilo
I have just tested this and it is working for me
I use an uint8_t and only break on counter % 2 == 0

[per1234]

@rei-vilo are you still having this issue with the latest nightly build of the Arduino IDE?

If so, please try to distill it down to a more minimal example. It's not clear to me whether the bug is dependent on the exact conditions produced by the fairly complex set up you provided to demonstrate #120, or whether you just happened to reuse that sketch by chance here and you would have had the same problem with even a conditional breakpoint in a minimal sketch.

[rei-vilo]

The same example with a local library and two breakpoints, but without the condition on the library breakpoints, stops at the two breakpoints.

However, stopping the debugging session fails with message kill failed for -4671Error: kill ESRCH.

Launching a new debugging sessions adds a second thread.

[per1234]

Thanks for your quick response!

but without the condition on the library breakpoints, stops at the two breakpoints.

What about with the condition? Does the problem still occur for you with the conditional breakpoint while using the nightly build?

Is the bug dependent on the conditional breakpoint being in a "local library", or does it also occur if you put a conditional breakpoint in a simple single file sketch?

However, stopping the debugging session fails with message kill failed for -4671Error: kill ESRCH.

This is a known bug (#527) introduced by the new version of the Theia IDE framework updated to (#489). before the 2.0.0-beta.12 release. Work is in progress now on a fix: #578 (will be in the next nightly build).

[rei-vilo]

The conditional breakpoint (line 10) in the main sketch is ignored.

[per1234]

Closing as fixed by #1706

After quite some deciphering of this unnecessarily complex report, I finally determined that it is the same as #412