Skip shell substitution #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should keep all of the path logic in gmake. This fixes an issue with uni-STC failing on MacOS and Ubuntu.
This commit separates build tree creation from dependency file creation. It also uses internal make functions over shelling out for loops.
area-8051
approved these changes
Feb 16, 2023
|
Merged, thanks a lot! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came here from ReedTripRadio. I ran into some errors while trying to compile on both MacOS and Raspbian, and it looks like other users have as well. It looks like make was getting confused with string and shell substitution.
This PR simplifies things by using make's internal string functions where possible. This works around the above compile errors and is more readable(IMHO).