Fix for missing scheme on ADMIN_APP_URL #1159
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we set the application URLs as
Twill Exception handler will end abnormally the application if an exception occurs:
For this to work, people need to remember to add the scheme to the Twill's admin URL too:
This is happening because parse_url() needs the scheme to correctly parse the URL, so this is good as it parses and finds the host:
But without the scheme we get:
This PR a quick fix for it, but this problem is actually deeper and needs us to fix it for good on 3.0.