Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Laravel 9 support #1243

Merged
merged 55 commits into from
Feb 25, 2022
Merged

[2.x] Laravel 9 support #1243

merged 55 commits into from
Feb 25, 2022

Conversation

ifox
Copy link
Member

@ifox ifox commented Nov 7, 2021

No description provided.

@ifox ifox marked this pull request as draft November 7, 2021 01:44
@ifox ifox changed the base branch from 2.x to main November 7, 2021 01:47
@ifox ifox changed the base branch from main to 2.x November 7, 2021 01:53
@ifox ifox changed the base branch from 2.x to main November 7, 2021 01:53
@haringsrob
Copy link
Contributor

haringsrob commented Nov 16, 2021 •
edited
Loading

idea: php 8 as well?

@ifox
Copy link
Member Author

ifox commented Nov 16, 2021

idea: php 8 as well?

PHP 8 is already supported, do you mean dropping support under 8?

@haringsrob
Copy link
Contributor

Yes (wouldnt mind making a pr adding as much type casting as possible :))

@ifox
Copy link
Member Author

ifox commented Nov 16, 2021

This time will come, but it is still too early to drop PHP 7, so that won't happen in Twill 3.

@ifox
Copy link
Member Author

ifox commented Nov 16, 2021

We can think about pushing this forward mid 2022, so that we support PHP 7 until 28 Nov 2022 which is the EOL for PHP 7.4.

@ifox
Copy link
Member Author

ifox commented Jan 6, 2022 •
edited
Loading

https://twitter.com/driesvints/status/1479004201774723073?t=h4272DRUPHa4e7Vw70o8Mw&s=19

First RC of Laravel 9 next week!

@ifox
Copy link
Member Author

ifox commented Jan 12, 2022

A beta has been tagged!

https://github.com/laravel/framework/releases/tag/v9.0.0-beta.1

@haringsrob haringsrob changed the base branch from main to 2.x January 18, 2022 08:59
@ifox
Copy link
Member Author

ifox commented Jan 25, 2022 •
edited
Loading

Made progress on this and submitted 3 support PRs to our dependencies:

haringsrob and others added 14 commits February 22, 2022 09:04
@haringsrob
Copy link
Contributor

Found one bug with crops, still trying to figure that one out.

@haringsrob
Copy link
Contributor

Hey @ifox I have a proposed fix for the cors issues that are occurring since 9.x

#1463

haringsrob
haringsrob previously approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@haringsrob haringsrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ifox, I did some more tests and I cannot find any issues.

Is there anything we should mention in the changelog?

@ifox ifox merged commit 2597e9d into 2.x Feb 25, 2022
@ifox ifox deleted the laravel-9-support branch March 4, 2022 00:39
@ifox ifox restored the laravel-9-support branch March 4, 2022 00:39
@ifox ifox deleted the laravel-9-support branch April 12, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haringsrob haringsrob haringsrob left review comments

Assignees
No one assigned
Labels
None yet
Projects
Twill roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ifox @haringsrob @kallefrombosnia @madalinignisca