[3.x] #1356: Add question to generate preview files for modules and blocks. #1377
Conversation
|
If we keep this for 3.x we do not have to deal with Laravel < 6 errors. |
works for me! |
ifox
changed the title
| @@ -54,12 +54,15 @@ public function getBlockMaker(): \A17\Twill\Services\Blocks\BlockMaker | |||
| */ | |||
| public function handle() | |||
| { | |||
| $generateView = $this->confirm('Should we also generate a view file for rendering the block?'); | |||
There was a problem hiding this comment.
@ifox Thinking since this is 3.x only, should we swap this with an option like --noPreview to skip preview generation and do it by default if no option is provided?
There was a problem hiding this comment.
Let's not do this as decoupled frontends have no use for this.
|
Hey @ifox, Thinking, shouldn't we generate a |
Codecov Report
@@ Coverage Diff @@
## 3.x #1377 +/- ##
============================================
+ Coverage 56.46% 56.63% +0.16%
- Complexity 3053 3058 +5
============================================
Files 242 241 -1
Lines 9301 9313 +12
============================================
+ Hits 5252 5274 +22
+ Misses 4049 4039 -10
Continue to review full report at Codecov.
|
Description
This adds a question to generate a module preview file and a block rendering file:
We should add this for:
a twill:make:blocka twill:install(to generate a block preview file)Related Issues
fixes #1356