Add an axios global handler and handle 401 errors within browser buttons #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioribeiro
changed the title
ifox
added a commit
that referenced
this pull request
Jul 21, 2021
Compile assets Also handle 419 errors Compile assets Merges #966
This reverts commit 3c78c93.
Compile assets Also handle 419 errors Compile assets
ifox
force-pushed
the
feature/axios-global-handler
branch
from
15691e1
to
13c4582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR injects a global error handler on Axios in order to catch 401 errors happening on places not handled today, like browser buttons. When forcing a session to expire manually, these are the outcomes
Clicking a browser button:
When trying to save the form I initially got this one, because the error was 419 (CSRF token mismatch) and not 401.
So now handling also 419, we get this when trying to save
Closes #964.