Make full filename large enough for filename and filepath components #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsobhani
pushed a commit
to bsobhani/ADCore
that referenced
this pull request
Apr 1, 2024
…me-length Make full filename large enough for filename and filepath components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues with full filenames being truncated due to the full filename being limited to the same size to the filename and filepath components.
This is a minimal change which increases the size of the full filename compared to the filename and filepath components. NDFileNexus.cpp already does something similar, but has a fixed format.
I'm not sure if the factor should be 3*MAX_FILENAME_LEN instead to account for possible extra characters in the file template on top of the substitution (although this will be slightly less than 256 characters depending on the formatting).