inconsistency with sp_private_key and sp_certificate values

[JLarky]

I see in some places those options can be undefined, but in others none. My usecase is to not use sp_private_key, but if I set it to undefined, but it becomes none and later check done for not (SP#esaml_sp.key =:= undefined) and it fails fails

[arekinath]

I know it might be a lot of trouble, and perhaps comes too late for you, but this should be fixed on the new API in the "develop" branch. There's a lot more documentation and examples in there, too.

Rather than having multiple places that deal with this now, there's just the esaml_sp record, and if you leave it without a key and certificate they will default to undefined and everything should deal with that.

I've tested with the examples/sp code, just commenting out the key = .. and certificate = .. lines and it seems to generate unsigned metadata and authnrequests fine.