Extract all bindings and support multiple certificates when decoding idp metadata #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, this would only look for HTTP-POST login locations. Now, it will extract any location it finds: post, redirect, or artifact. The way this is achieved is not the most beautiful, but allows for easy matching when `#esaml_idp_metadata` is used. Also adds okta-ish test metadata.
Changes the `esaml_idp_metadata` record: `certificate` -> `certificates`, now of type `[binary()]` instead of `binary()`, with `undefined` instead of `[]` winning if there's nothing in the metadata xml document. Test data included (Azure AD).
kmacgugan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract all bindings when decoding idp metadata.
-Before, this would only look for HTTP-POST login locations. Now, it will
extract any location it finds: post, redirect, or artifact. The way this
is achieved is not the most beautiful, but allows for easy matching when
#esaml_idp_metadatais used.Support multiple certificates from idp metadata.
-Changes the
esaml_idp_metadatarecord:certificate->certificates,now of type
[binary()]instead ofbinary(), withundefinedinsteadof
[]winning if there's nothing in the metadata xml document.Adds okta-ish and azure test metadata.