[Do not merge] Testing for 5436 #1012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend process GUCs marked as GUC_GPDB_NEED_SYNC are overwritten by coordinator upon receiving a new connection. The coordinator sends it's configuration to the segments the same way as if it were a frontend communicating with the coordinator. This means the default priority for these GUCs becomes client priority. Previously, when gpstop -u was executed, it sent a SIGHUP signal, prompting the coordinator and segments to re-read their configuration files. However, the priority of options derived from the configuration file is lower than that of client options. This difference caused the segments to ignore overwritten GUCs when they re-read their configuration files, and these GUCs were not re-dispatched by the QD either. This situation resulted in a desynchronization of GUCs that are required to be synchronized between the coordinator and the segments. The solution is to explicitly dispatch the changed configuration from the coordinator to the segments, similar to how it is done when initializing the backend process. When the QD receives a SIGHUP signal, it reads its configuration file to identify any GUCs that have been modified. If these GUCs are marked with the GUC_GPDB_NEED_SYNC flag, the QD dispatches SET commands containing these modified GUCs to the QEs. To differentiate between this type of synchronization and user-initiated SET commands, a flag GP_OPT_SYNCHRONIZATION_SET has been introduced to the distributed transaction options. Changes from original commit: - In `guc-file.l` move the return value of `ProcessConfigFileInternal` to an out parameter `changed_gucs_out`. - Add memory context switching to it so that the `changed_gucs_out` list is in the correct memory context. - Change GUC parameter in the test from `backslash_quote` to `constraint_exclusion` since `backslash_quote` now has a sync flag. (cherry picked from commit 6934f3d)
silent-observer
force-pushed
the
test-5436
branch
from
cfe5a03
to
b785086
Compare
silent-observer
force-pushed
the
test-5436
branch
from
3205f03
to
2620c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.