ADBDEV-6041: Migrate ABI tests to Ubuntu 22 #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silent-observer
force-pushed
the
ADBDEV-6041
branch
from
01bfcb0
to
5bb6fdd
Compare
silent-observer
changed the title
|
Allure report https://allure.adsw.io/launch/79491 |
bandetto
reviewed
Sep 6, 2024
Yes, it actually detected some issues that weren't detected before due to old GCC version (see #1031) |
|
Allure report https://allure.adsw.io/launch/79593 |
bandetto
approved these changes
Sep 6, 2024
whitehawk
approved these changes
Sep 8, 2024
|
Allure report https://allure.adsw.io/launch/79749 |
dnskvlnk
pushed a commit
that referenced
this pull request
Sep 16, 2024
Now ABI tests in Github Actions fully run on Ubuntu 22. Notable changes: Removed dependence on gcr.io/data-gpdb-public-images/gpdb6-centos7-build image (likely maintained by upstream), now building on raw ubuntu-latest from Github. Removed custom installation of Universal Ctags, now using package from Ubuntu repo. Building libxerces here because our package is not available for GA. Added-gdwarf-4 GCC flag (needed for abi-checker and GCC 11), which also enabled source compatibility tests. Removed --with-quicklz flag since QuickLZ is deprecated and not available in Ubuntu packages (adding it would require another build step). Ticket: ADBDEV-6041
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate ABI tests to Ubuntu 22
Now ABI tests in Github Actions fully run on Ubuntu 22. Notable changes:
gcr.io/data-gpdb-public-images/gpdb6-centos7-buildimage (likely maintained by upstream), now building on raw
ubuntu-latestfrom Github.
Ubuntu repo.
-gdwarf-4GCC flag (needed for abi-checker and GCC 11), which alsoenabled source compatibility tests.
--with-quicklzflag since QuickLZ is deprecated and not availablein Ubuntu packages (adding it would require another build step).