ADBDEV-2833 V2 DRAFT #677
ADBDEV-2833 V2 DRAFT #677
Conversation
Delete operation (in case of partitioned tables) now detects the partition (table), where deletion should be performed by the `tableoid` from the slot.tts_tuple, instead of calling `slot_get_partition` (this function could detect the wrong partition (table) in case of default partition exchaning). In case of updeate operation (which is a combination of delete and insert operations) insert still uses `slot_get_partition`.
tableoid added to targetlist only if table is partitioned
Pass tableoid through ORCA planner for delete/update operations on the partitioned tables - restored work with table oid inside planner nodes (like DML) - fix the unit tests - add hash of tableoid add serialization
We may avoid adding tableoid attribute from targetlist of input Query node because targetlist does not participate in Query DXL tree creation. tableoid_colid for CDXLLogicalDelete is taken (GetSystemColId) from var_to_colid_mapping, which is firstly filled directly from TableDescriptor, which is created at CDXLLogicalSelect stage and which definitely has tableoid
The error is thrown in case when deletion is taken on root partition, but the tubleoid is absent. execDML is changed with adding an additional condition in the if clause because on DELETE the partition selection is not performed.
|
Allure report https://allure-ee.adsw.io/launch/62049 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/977975 |
|
Failed job Regression tests with Postgres on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/977967 |
|
Allure report https://allure-ee.adsw.io/launch/62072 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/978937 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/978938 |
|
Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/978931 |
|
Failed job Regression tests with ORCA on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/978932 |
|
ORCA tests have failed on explain tests from ADBDEV-4207 fd5939d. Can be easily fixed |
|
Allure report https://allure-ee.adsw.io/launch/63555 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1045914 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1045915 |
|
Failed job Behave tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1045912 |
No description provided.