ADBDEV-5039: Do not treat interruption of LDAP requests by signals as an auth error. #899
Conversation
|
Failed job Build for x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1199933 |
|
Failed job Build for ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1199934 |
|
bender build |
|
Failed job Build for ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200021 |
|
Failed job Build for x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200020 |
|
Allure report https://allure.adsw.io/launch/67349 |
RekGRpth
changed the title
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200179 |
|
Failed job Regression tests with ORCA on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200172 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1200180 |
|
Summary 'Interruption of LDAP requests by signals shouldn't be treated as auth error' looks violating wiki checklist for patch description, item 2.2 (summary should be in Imperative Mood). Following wiki I guess it should be smth like "Do not treat interruption of LDAP requests by signals as auth error" or similar. |
|
In the PR description there is no explanation why no tests were added. Refer to wiki checklist for patch description, item 3.1. |
RekGRpth
changed the title
updated
added |
|
Allure report https://allure.adsw.io/launch/68656 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1261006 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1261007 |
When authorizing via ldap, the ldap_simple_bind_s function may return an error. This occurs when an internal call to the ldap_int_poll utility function is interrupted by a signal. The openldap library can handle this properly using the LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select() system call to be restarted when interrupted by a signal. The default value is LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires explicitly specifying the -llber library to build) after ldap is initialized. Tests are not provided because they require a separate LDAP container and the error is not reproducible in a stable manner.
|
Allure report https://allure.adsw.io/launch/68728 |
|
Allure report https://allure.adsw.io/launch/68736 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1267217 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1267218 |
|
bender build |
|
Allure report https://allure.adsw.io/launch/69397 |
|
Failed job Resource group isolation tests on x86_64: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1302730 |
|
Failed job Resource group isolation tests on ppc64le: https://gitlab.adsw.io/arenadata/github_mirroring/gpdb/-/jobs/1302731 |
…r (port changes from #899) When authorizing via ldap, the ldap_simple_bind_s function may return an error. This occurs when an internal call to the ldap_int_poll utility function is interrupted by a signal. The openldap library can handle this properly using the LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select() system call to be restarted when interrupted by a signal. The default value is LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires explicitly specifying the -llber library to build) after ldap is initialized. Tests are not provided because they require a separate LDAP container and the error is not reproducible in a stable manner. Co-authored-by: Georgy Shelkovy <g.shelkovy@arenadata.io>
…r (port changes from #899) When authorizing via ldap, the ldap_simple_bind_s function may return an error. This occurs when an internal call to the ldap_int_poll utility function is interrupted by a signal. The openldap library can handle this properly using the LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select() system call to be restarted when interrupted by a signal. The default value is LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires explicitly specifying the -llber library to build) after ldap is initialized. Tests are not provided because they require a separate LDAP container and the error is not reproducible in a stable manner. Co-authored-by: Georgy Shelkovy <g.shelkovy@arenadata.io>
…r. (#899) When authorizing via LDAP, the ldap_simple_bind_s function may return an error. This occurs when an internal call to the ldap_int_poll utility function is interrupted by a signal. The openldap library can handle this properly using the LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select() system call to be restarted when interrupted by a signal. The default value is LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires explicitly specifying the -llber library to build) after ldap is initialized. Tests are not provided because they require a separate LDAP container and the error is not reproducible in a stable manner. (cherry picked from commit edacbaf)
…r. (#899) When authorizing via LDAP, the ldap_simple_bind_s function may return an error. This occurs when an internal call to the ldap_int_poll utility function is interrupted by a signal. The openldap library can handle this properly using the LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select() system call to be restarted when interrupted by a signal. The default value is LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires explicitly specifying the -llber library to build) after ldap is initialized. Tests are not provided because they require a separate LDAP container and the error is not reproducible in a stable manner. Changes for 7.2.0: Fix error reporting to match the surrounding code. (cherry picked from commit edacbaf)
…r. (#899) When authorizing via LDAP, the ldap_simple_bind_s function may return an error. This occurs when an internal call to the ldap_int_poll utility function is interrupted by a signal. The openldap library can handle this properly using the LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select() system call to be restarted when interrupted by a signal. The default value is LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires explicitly specifying the -llber library to build) after ldap is initialized. Tests are not provided because they require a separate LDAP container and the error is not reproducible in a stable manner. Changes for 7.2.0: Fix error reporting to match the surrounding code. (cherry picked from commit edacbaf)
…r. (#899) When authorizing via LDAP, the ldap_simple_bind_s function may return an error. This occurs when an internal call to the ldap_int_poll utility function is interrupted by a signal. The openldap library can handle this properly using the LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select() system call to be restarted when interrupted by a signal. The default value is LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires explicitly specifying the -llber library to build) after ldap is initialized. Tests are not provided because they require a separate LDAP container and the error is not reproducible in a stable manner. Changes for 7.2.0: Fix error reporting to match the surrounding code. (cherry picked from commit edacbaf)
Do not treat interruption of LDAP requests by signals as an auth error.
When authorizing via ldap, the ldap_simple_bind_s function may return an error.
This occurs when an internal call to the ldap_int_poll utility function is
interrupted by a signal. The openldap library can handle this properly using the
LDAP_OPT_RESTART option. Setting this option to LDAP_OPT_ON causes the select()
system call to be restarted when interrupted by a signal. The default value is
LDAP_OPT_OFF. This patch sets the value to LDAP_OPT_ON (also it requires
explicitly specifying the -llber library to build) after ldap is initialized.
Tests are not provided because they require a separate LDAP container and the
error is not reproducible in a stable manner.