6.27.1 sync

.abi-check/6.26.1/postgres.symbols.ignore

@@ -1 +1,2 @@
 ConfigureNamesBool_gp
+ConfigureNamesInt_gp

.abi-check/6.26.3/postgres.symbols.ignore

@@ -0,0 +1 @@
+ConfigureNamesBool_gp

.abi-check/6.26.4/postgres.symbols.ignore

@@ -0,0 +1 @@
+ConfigureNamesBool_gp

.abi-check/6.26.4/postgres.types.ignore

@@ -0,0 +1 @@
+AORelHashEntryData

.abi-check/6.27.0/postgres.symbols.ignore

@@ -0,0 +1 @@
+ConfigureNamesInt_gp

concourse/scripts/builds/GpBuild.py

@@ -57,7 +57,7 @@ def run_explain_test_suite(self, dbexists):
 
         source_env_cmd = ''
         if dbexists:
-            source_env_cmd='source {0}/greenplum_path.sh && source ~/.bash_profile '.format(INSTALL_DIR)
+            source_env_cmd='source {0}/greenplum_path.sh && source ~/.bash_profile && source gpdb_src/gpAux/gpdemo/gpdemo-env.sh'.format(INSTALL_DIR)
         else:
             source_env_cmd = "source {0}/greenplum_path.sh && source gpdb_src/gpAux/gpdemo/gpdemo-env.sh".format(INSTALL_DIR)
             status = self.create_demo_cluster(INSTALL_DIR, True)

config/c-compiler.m4

@@ -252,6 +252,34 @@ fi])# PGAC_C_BUILTIN_CONSTANT_P
 
 
 
+# PGAC_C_BUILTIN_OP_OVERFLOW
+# -------------------------
+# Check if the C compiler understands __builtin_$op_overflow(),
+# and define HAVE__BUILTIN_OP_OVERFLOW if so.
+#
+# Check for the most complicated case, 64 bit multiplication, as a
+# proxy for all of the operations.  To detect the case where the compiler
+# knows the function but library support is missing, we must link not just
+# compile, and store the results in global variables so the compiler doesn't
+# optimize away the call.
+AC_DEFUN([PGAC_C_BUILTIN_OP_OVERFLOW],
+[AC_CACHE_CHECK(for __builtin_mul_overflow, pgac_cv__builtin_op_overflow,
+[AC_LINK_IFELSE([AC_LANG_PROGRAM([
+PG_INT64_TYPE a = 1;
+PG_INT64_TYPE b = 1;
+PG_INT64_TYPE result;
+int oflo;
+],
+[oflo = __builtin_mul_overflow(a, b, &result);])],
+[pgac_cv__builtin_op_overflow=yes],
+[pgac_cv__builtin_op_overflow=no])])
+if test x"$pgac_cv__builtin_op_overflow" = xyes ; then
+AC_DEFINE(HAVE__BUILTIN_OP_OVERFLOW, 1,
+          [Define to 1 if your compiler understands __builtin_$op_overflow.])
+fi])# PGAC_C_BUILTIN_OP_OVERFLOW
+
+
+
 # PGAC_C_BUILTIN_UNREACHABLE
 # --------------------------
 # Check if the C compiler understands __builtin_unreachable(),

configure

@@ -17614,6 +17614,45 @@ esac
 
 fi
 
+# has to be down here, rather than with the other builtins, because
+# the test uses PG_INT64_TYPE.
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for __builtin_mul_overflow" >&5
+$as_echo_n "checking for __builtin_mul_overflow... " >&6; }
+if ${pgac_cv__builtin_op_overflow+:} false; then :
+  $as_echo_n "(cached) " >&6
+else
+  cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h.  */
+
+PG_INT64_TYPE a = 1;
+PG_INT64_TYPE b = 1;
+PG_INT64_TYPE result;
+int oflo;
+
+int
+main ()
+{
+oflo = __builtin_mul_overflow(a, b, &result);
+  ;
+  return 0;
+}
+_ACEOF
+if ac_fn_c_try_link "$LINENO"; then :
+  pgac_cv__builtin_op_overflow=yes
+else
+  pgac_cv__builtin_op_overflow=no
+fi
+rm -f core conftest.err conftest.$ac_objext \
+    conftest$ac_exeext conftest.$ac_ext
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $pgac_cv__builtin_op_overflow" >&5
+$as_echo "$pgac_cv__builtin_op_overflow" >&6; }
+if test x"$pgac_cv__builtin_op_overflow" = xyes ; then
+
+$as_echo "#define HAVE__BUILTIN_OP_OVERFLOW 1" >>confdefs.h
+
+fi
+
 # Check size of void *, size_t (enables tweaks for > 32bit address space)
 # The cast to long int works around a bug in the HP C Compiler
 # version HP92453-01 B.11.11.23709.GP, which incorrectly rejects

configure.in

@@ -2351,6 +2351,10 @@ if test $pgac_need_repl_snprintf = yes; then
   AC_LIBOBJ(snprintf)
 fi
 
+# has to be down here, rather than with the other builtins, because
+# the test uses PG_INT64_TYPE.
+PGAC_C_BUILTIN_OP_OVERFLOW
+
 # Check size of void *, size_t (enables tweaks for > 32bit address space)
 AC_CHECK_SIZEOF([void *])
 AC_CHECK_SIZEOF([size_t])

contrib/pg_upgrade/greenplum/check_gp.c

@@ -1183,6 +1183,16 @@ check_views_with_unsupported_lag_lead_function(void)
 		bool		db_used = false;
 
 		conn = connectToServer(&old_cluster, active_db->db_name);
+
+		/*
+		 * Disabling track_counts results in a large performance improvement of
+		 * several orders of magnitude when walking the views. This is because
+		 * calling try_relation_open to get a handle of the view calls
+		 * pgstat_initstats which has been profiled to be very expensive. For
+		 * our purposes, this is not needed and disabled for performance.
+		 */
+		PQclear(executeQueryOrDie(conn, "SET track_counts TO off;"));
+
 		res = executeQueryOrDie(conn,
 								"SELECT ev_class::regclass::text viewname  "
 								"FROM pg_rewrite pgr "
@@ -1191,6 +1201,7 @@ check_views_with_unsupported_lag_lead_function(void)
 								"	FROM (SELECT DISTINCT oid FROM pg_catalog.pg_proc WHERE (proname, pronamespace) in "
 								"			(('lag', 11), ('lead', 11))AND proargtypes[1]=20)s1);");
 
+		PQclear(executeQueryOrDie(conn, "RESET track_counts;"));
 		ntups = PQntuples(res);
 
 		i_viewname = PQfnumber(res, "viewname");
@@ -1253,6 +1264,15 @@ check_views_with_fabricated_anyarray_casts()
 		conn = connectToServer(&old_cluster, active_db->db_name);
 		PQclear(executeQueryOrDie(conn, "SET search_path TO 'public';"));
 
+		/*
+		 * Disabling track_counts results in a large performance improvement of
+		 * several orders of magnitude when walking the views. This is because
+		 * calling try_relation_open to get a handle of the view calls
+		 * pgstat_initstats which has been profiled to be very expensive. For
+		 * our purposes, this is not needed and disabled for performance.
+		 */
+		PQclear(executeQueryOrDie(conn, "SET track_counts TO off;"));
+
 		/* Install check support function */
 		PQclear(executeQueryOrDie(conn,
 									 "CREATE OR REPLACE FUNCTION "
@@ -1268,6 +1288,7 @@ check_views_with_fabricated_anyarray_casts()
 
 		PQclear(executeQueryOrDie(conn, "DROP FUNCTION view_has_anyarray_casts(OID);"));
 		PQclear(executeQueryOrDie(conn, "SET search_path to 'pg_catalog';"));
+		PQclear(executeQueryOrDie(conn, "RESET track_counts;"));
 
 		ntups = PQntuples(res);
 		i_viewname = PQfnumber(res, "badviewname");
@@ -1330,6 +1351,14 @@ check_views_with_fabricated_unknown_casts()
 
 		conn = connectToServer(&old_cluster, active_db->db_name);
 		PQclear(executeQueryOrDie(conn, "SET search_path TO 'public';"));
+		/*
+		 * Disabling track_counts results in a large performance improvement of
+		 * several orders of magnitude when walking the views. This is because
+		 * calling try_relation_open to get a handle of the view calls
+		 * pgstat_initstats which has been profiled to be very expensive. For
+		 * our purposes, this is not needed and disabled for performance.
+		 */
+		PQclear(executeQueryOrDie(conn, "SET track_counts TO off;"));
 
 		/* Install check support function */
 		PQclear(executeQueryOrDie(conn,
@@ -1346,6 +1375,7 @@ check_views_with_fabricated_unknown_casts()
 
 		PQclear(executeQueryOrDie(conn, "DROP FUNCTION view_has_unknown_casts(OID);"));
 		PQclear(executeQueryOrDie(conn, "SET search_path to 'pg_catalog';"));
+		PQclear(executeQueryOrDie(conn, "RESET track_counts;"));
 
 		ntups = PQntuples(res);
 		i_viewname = PQfnumber(res, "badviewname");
@@ -1415,6 +1445,14 @@ check_views_referencing_deprecated_tables()
 
 		conn = connectToServer(&old_cluster, active_db->db_name);
 		PQclear(executeQueryOrDie(conn, "SET search_path TO 'public';"));
+		/*
+		 * Disabling track_counts results in a large performance improvement of
+		 * several orders of magnitude when walking the views. This is because
+		 * calling try_relation_open to get a handle of the view calls
+		 * pgstat_initstats which has been profiled to be very expensive. For
+		 * our purposes, this is not needed and disabled for performance.
+		 */
+		PQclear(executeQueryOrDie(conn, "SET track_counts TO off;"));
 
 		/* Install check support function */
 		PQclear(executeQueryOrDie(conn,
@@ -1432,6 +1470,7 @@ check_views_referencing_deprecated_tables()
 
 		PQclear(executeQueryOrDie(conn, "DROP FUNCTION view_references_deprecated_tables(OID);"));
 		PQclear(executeQueryOrDie(conn, "SET search_path to 'pg_catalog';"));
+		PQclear(executeQueryOrDie(conn, "RESET track_counts;"));
 
 		ntups = PQntuples(res);
 		i_viewname = PQfnumber(res, "badviewname");
@@ -1502,6 +1541,14 @@ check_views_referencing_deprecated_columns()
 
 		conn = connectToServer(&old_cluster, active_db->db_name);
 		PQclear(executeQueryOrDie(conn, "SET search_path TO 'public';"));
+		/*
+		 * Disabling track_counts results in a large performance improvement of
+		 * several orders of magnitude when walking the views. This is because
+		 * calling try_relation_open to get a handle of the view calls
+		 * pgstat_initstats which has been profiled to be very expensive. For
+		 * our purposes, this is not needed and disabled for performance.
+		 */
+		PQclear(executeQueryOrDie(conn, "SET track_counts TO off;"));
 
 		/* Install check support function */
 		PQclear(executeQueryOrDie(conn,
@@ -1519,6 +1566,7 @@ check_views_referencing_deprecated_columns()
 
 		PQclear(executeQueryOrDie(conn, "DROP FUNCTION view_references_deprecated_columns(OID);"));
 		PQclear(executeQueryOrDie(conn, "SET search_path to 'pg_catalog';"));
+		PQclear(executeQueryOrDie(conn, "RESET track_counts;"));
 
 		ntups = PQntuples(res);
 		i_viewname = PQfnumber(res, "badviewname");