Pgx binary value #83
Merged
Pgx binary value #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
brendanlong
force-pushed
the
pgx-binary-value
branch
from
fe37774
to
c3f2163
Compare
anuragsoni
approved these changes
May 7, 2020
This will allow people to pass binary strings without breaking normal strings.
brendanlong
force-pushed
the
pgx-binary-value
branch
from
c3f2163
to
c77bd64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces new
Pgx_value.of_binaryandto_binaryfunctions and uses them instead of using (incorrect) escaping for all strings.I think this will fix #38, although people will need to explicitly use the binary type to get escaping in the future.