Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI improvements #96

Merged
merged 2 commits into from
May 12, 2020
Merged

CI improvements #96

merged 2 commits into from
May 12, 2020

Conversation

brendanlong
Copy link
Contributor

@brendanlong brendanlong commented May 12, 2020 •
edited
Loading

  • Add dune-release lint
  • Build with -p
  • Build before installing test deps

@brendanlong brendanlong self-assigned this May 12, 2020
@brendanlong brendanlong force-pushed the ci-improvements branch 3 times, most recently from d324342 to b54ee6f Compare May 12, 2020 17:35
@coveralls
Copy link

coveralls commented May 12, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 66.848% when pulling 4c60033 on ci-improvements into cc67529 on master.

@pull-request-size pull-request-size bot added size/M and removed size/S labels May 12, 2020
@brendanlong brendanlong changed the title Add dune-release lint to CI build CI improvements May 12, 2020
@brendanlong
Add dune-release lint to CI build
49129bd
@brendanlong
Build before installing test deps and build with -p in CI
4c60033 
This should catch two cases we could miss previously:

- If a test dep is required for the normal build
- If two packages depend on each other in a way that isn't declared
@brendanlong brendanlong marked this pull request as ready for review May 12, 2020 17:55
@brendanlong brendanlong merged commit 36759af into master May 12, 2020
@brendanlong brendanlong deleted the ci-improvements branch May 12, 2020 18:16
This was referenced May 12, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuragsoni anuragsoni anuragsoni approved these changes

Assignees

@brendanlong brendanlong

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendanlong @coveralls @anuragsoni