Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR - Allows individual control of power and mode #10829

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

nao-pon
Copy link

@nao-pon nao-pon commented Feb 4, 2021

Description:

Power and mode must be individually controllable. Some devices may not function properly if the mode is also turned off when the power is turned off.

see. crankyoldgit/IRremoteESP8266#1402

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works on Tasmota core ESP32 V.1.0.5-rc6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Power and mode must be individually controllable. Some devices may not function properly if the mode is also turned off when the power is turned off.

see. crankyoldgit/IRremoteESP8266#1402
@ascillato2 ascillato2 changed the title Allows individual control of power and mode IR - Allows individual control of power and mode Feb 4, 2021
@arendst arendst merged commit 96c4f3d into arendst:development Feb 4, 2021
nao-pon added a commit to nao-pon/Tasmota-IRHVAC that referenced this pull request Feb 4, 2021
The final mode other than OFF is retained, and it can be saved and
restored. This will do the following:

- From the OFF state, when the Turn on command is accepted, the
operation starts in the previous mode.
- With the option "keep_mode_when_off: True", when sending an OFF
command, only Power is Off and Mode sends the previous mode.
  - crankyoldgit/IRremoteESP8266#1402
  - arendst/Tasmota#10829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants