Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNX fix javascript scrumbled by quote char #16711

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Oct 2, 2022

Description:

Related issue (if applicable): fixes #16707

Javascript alert('" D_KNX_WARNING '"); was broken by Italian translation introducing a ' in the text
Replaced the single-quote by double-quote in the Javascript code

@bovirus Thanks a lot for this one. It took me 2 hours to figure it out 🤣
Please do not PR translation for features that you have not tested !

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@barbudor
Copy link
Contributor Author

barbudor commented Oct 2, 2022

ping @platini76 for merging

@ascillato2
Copy link
Collaborator

Good one!!! Thanks for fixing.

@ascillato2 ascillato2 merged commit 7d8d512 into arendst:development Oct 2, 2022
@barbudor barbudor deleted the fix_knx_javascript branch October 22, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem issue on compiling knx tasmota with ITA language
2 participants