KNX fix javascript scrumbled by quote char #16711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #16707
Javascript
alert('" D_KNX_WARNING '");
was broken by Italian translation introducing a'
in the textReplaced the single-quote by double-quote in the Javascript code
@bovirus Thanks a lot for this one. It took me 2 hours to figure it out 🤣
Please do not PR translation for features that you have not tested !
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass