Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Support Solar Solax X1 Inverters #6196

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Initial Support Solar Solax X1 Inverters #6196

merged 2 commits into from
Aug 9, 2019

Conversation

pablozg
Copy link
Contributor

@pablozg pablozg commented Aug 9, 2019

Description:

Support for solax X1 solar inverters, getting all readables values by RS485 port, using a RS485 to TTL board and connected to hardware Serial of ESP8266

Checklist:

  • The pull request is done against the latest dev branch
  • [X ] Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.3.0, 2.4.2 and 2.5.2 (Working with 2.5.2)
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst
Copy link
Owner

arendst commented Aug 9, 2019

I'll merge but there are some actions I need to take:

  • No need to use ifdefs in language files; if the define is not used it os not compiled either
  • Fixed use of celsius is wrong; need to be changed to tasmota global temperature handling
  • Consolidate code to decrease code size considerably

In the end it needs to be tested by you as I do not own the device.

@arendst arendst merged commit 6417444 into arendst:development Aug 9, 2019
@pablozg
Copy link
Contributor Author

pablozg commented Aug 9, 2019

It's ok for me, my programming level is limited and it's a good chance to learn about code optimization. If you need I can send you the rs485 protocol used in solax inverters.

@arendst
Copy link
Owner

arendst commented Aug 9, 2019

Well there wasn't much to gain other than masking the debug messages.

Thx for your contribution

@pablozg
Copy link
Contributor Author

pablozg commented Aug 9, 2019

I have tested and is working without issues. By the moment the code only support one inverter at once (I only have one Inverter), but in the future if anyone needs a multi-inverter configuration I can try to make some changes.

Thanks for your continuous work with tasmota.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants