Move '#include user_config_override.h' in 'my_user_config.h'. #6330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moved
#include user_config_override.h
at the end ofmy_user_config.h
instead of insidesonoff.ino
.Benefit: allows user_config_override.h to change parameters like USE_MQTT_TLS.
Downside: generates 3 warnings instead of 1 when
Theo, I don't see any wrong side effect for this, but I would like your advice on this one.
Checklist: