Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report signal strength in dBm over MQTT #7145

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

RoadRunnr
Copy link
Contributor

@RoadRunnr RoadRunnr commented Dec 8, 2019

Description:

  • report signal strength in dBm over MQTT
  • include dBm in debug log and in WebIf information display.

Related issue (if applicable): fixes #7113

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.6.1
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst
Copy link
Owner

arendst commented Dec 8, 2019

Great!

As for me just get rid of the setoption. Makes code smaller and dBm is implemented nicely.

So pls remove setoption and I'll merge

@ascillato
Copy link
Contributor

ascillato commented Dec 8, 2019

So as to not break backwards compatibility, the JSON message will include both values? RSSI % and dBm?

@arendst
Copy link
Owner

arendst commented Dec 8, 2019

It's just an additional json field/value pair so should be no issue for json processors.

@arendst
Copy link
Owner

arendst commented Dec 8, 2019

Ah I see. I choose the wrong name for rssi quality...

@arendst
Copy link
Owner

arendst commented Dec 8, 2019

But with this solution you have no idea if it's rssi quality or just rssi.

We need a new value pair for rssi in dBm

@ascillato
Copy link
Contributor

We need a new value pair for rssi in dBm

Totally agree.

Also include dBm in debug log and in WebIf information display.
@RoadRunnr RoadRunnr changed the title add SetOption78 to report RSSI in dBm over MQTT report signal strength in dBm over MQTT Dec 8, 2019
@RoadRunnr
Copy link
Contributor Author

updated, SetOption removed, the signal strength is now reported in dBm in a new JSON node called "Signal".

About the JSON, I opted for keeping it as short as possible, it would also be sensible to call it "SignalStrength". Not sure which one is better.

@arendst arendst merged commit 9ecb48c into arendst:development Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement option to present WiFi RSSI in dbm instead of percent
3 participants