Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scheduler #73

Merged
merged 78 commits into from
Nov 11, 2018
Merged

Refactor scheduler #73

merged 78 commits into from
Nov 11, 2018

Conversation

realityforge
Copy link
Member

No description provided.

@realityforge
Add some TODO items
d740003
@realityforge
Extract a TaskQueue abstraction
0d39ae7
@realityforge
Remove completed task
cca00b0
@realityforge
Rename method
44aaf1b
@realityforge
Add another TaskQueue implementation
b7746f7
@realityforge
Make sure observers are marked as executed otherwise the system can n…
839c0e8 
…ot continue operating
@realityforge
Regenerate statistics
8d8c0e0
@realityforge
Rename support method
0803e71
@realityforge
Simplify code
b2bebc5
@realityforge
Remove unthrown exception
9c3826f
@realityforge
Whitespace
fb7205c
@realityforge
Expose compile time configuration setting on Arez util class
b7eef69
@realityforge
Extract out task executor infrastructure
bb44158
@realityforge
Add some TODO items
1b17c13
@realityforge
Start to separate representation of schedulable work from Observer so…
47c56ee 
… that other elements can be scheduled over time.
@realityforge
Add a TODO
8566ccd
@realityforge
Regenerate statistics
dde8645
@realityforge
Expose accessor for buffers capacity
bca4ce3
@realityforge
Add accessor for priority count
9c5a985
@realityforge
Make ctos package access so that they can be tested
e782e00
@realityforge
Remove unused constructor
8ac97fa
@realityforge
Make defaults package access so easier to test
03a0574
@realityforge
Remove public qualifier
58fa30a
@realityforge
Turn assert into invariant check
5cefbd1
@realityforge
Cleanup language used in assertion error
455711f
@realityforge
Remove default constructor in MultiPriorityTaskQueue as only one inst…
f63f01e 
…ance created in production code
@realityforge
Improve invariant failure message
8d11e38
@realityforge
Remove default constructor
f810a11
@realityforge
Add some basic unit testing for MultiPriorityTaskQueue
9d99ad9
@realityforge
Add notes to TODO
a2219a5
@realityforge
Simplify method
e395729
@realityforge
Inline method
de265fc
@realityforge
Add FifoTaskQueue test
d636ec3
@realityforge
Add ErrorProne tasks
1c782b5
@realityforge
Record a change
fd64cdd
@realityforge
Add TODO
d506f52
@realityforge
Remove assertions for classes that have been removed
55e7d01
@realityforge
Update assertions for renamed classes
62f4c03
@realityforge
Add assertions in ArezBuildAsserts to ensure names are ommitted if …
4257b27 
…names are disabled
@realityforge
Verify context field omitted if zones not enabled
0d7e46a
@realityforge
Add TODO item
c512ba5
@realityforge
Remove rule that does not match anything
9e8ca57
@realityforge
Add assertions in ArezBuildAsserts to verify the Locator interfac…
1a65539 
…e and supporting infrastructure is omitted if references are disabled.
@realityforge
Remove completed action
d8273b7
@realityforge
Add TODO item
15ab711
@realityforge
Remove TODO item covered by other items
3486263
@realityforge
Remove invariant failure duplicating failure inside queue
d6ba12e
@realityforge
Restructure the code so that the task queue is responsible for managi…
1a8c137 
…ng the setting of flag indicating whether task is queued or not
@realityforge
Remove completed task
c5565df
@realityforge
Add TODO task
18a18a9
@realityforge
Regenerate statistics
c61b994
@realityforge
Cleanup the javadocs associated with name of actions
334a07c
@realityforge
Merge the deferred dispose task queue into normal task queue and remo…
c7cfd8d 
…ve the ReactionScheduler that no longer contained any code
@realityforge
Rename the compile time constant `arez.purge_reactions_when_runaway_d…
e9039d7 
…etected` to `arez.purge_tasks_when_runaway_detected` and rename all related infrastructure.
@realityforge
Add assertions in ArezBuildAsserts to verify the PropertyAccessor…
f302f1b 
… interface and

supporting infrastructure is omitted if property introspectors are disabled.
@realityforge
Inline some variables
fc9f6ae
@realityforge
Remove task that decided against
21a9cee
@codecov-io
Copy link

codecov-io commented Nov 11, 2018 •
edited
Loading

Codecov Report

Merging #73 into master will decrease coverage by 0.35%.
The diff coverage is 89.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     90.83%   90.47%   -0.36%     
+ Complexity     3178     3169       -9     
============================================
  Files            91       94       +3     
  Lines          7526     7558      +32     
  Branches       1265     1261       -4     
============================================
+ Hits           6836     6838       +2     
- Misses          125      126       +1     
- Partials        565      594      +29
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/arez/Flags.java 87.23% <ø> (-2.13%) 58 <0> (-1)
...ore/src/main/java/arez/component/MemoizeCache.java 81.81% <0%> (-1.14%) 52 <0> (ø)
core/src/main/java/arez/Observer.java 86.66% <100%> (-2.49%) 215 <1> (-11)
core/src/main/java/arez/CircularBuffer.java 96.7% <100%> (+0.03%) 32 <1> (+1) ⬆️
core/src/main/java/arez/Arez.java 87.5% <100%> (-3.81%) 27 <1> (ø)
.../main/java/arez/processor/ComponentDescriptor.java 96.42% <100%> (ø) 633 <0> (ø) ⬇️
core/src/main/java/arez/ArezTestUtil.java 93.43% <100%> (ø) 50 <3> (ø) ⬇️
core/src/main/java/arez/FifoTaskQueue.java 100% <100%> (ø) 14 <14> (?)
core/src/main/java/arez/ObserverInfoImpl.java 86.04% <100%> (ø) 27 <1> (ø) ⬇️
core/src/main/java/arez/ArezConfig.java 61.64% <75%> (ø) 18 <1> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b3ced...21a9cee. Read the comment docs.

@realityforge realityforge merged commit 4b89d58 into master Nov 11, 2018
@realityforge realityforge deleted the ExtractTaskQueue branch November 11, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realityforge @codecov-io