-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banshee crashes when playing videos #3
Comments
Some details on the crash would be handy, every video file or just MKVs? Personally, since I don't use Banshee for video I agree with your suggestion and I explored doing it a while ago - the changes are quite far-reaching and mean an ABI break for plugins. The other issue I thought about was our ability to contribute upstream and removing a major feature might hurt that. On balance, for now I think we'll leave it in. |
Ok, curiosity didn't let to stop me ;) Installed software versions: Is there any kind of upstream maintainer at the moment? Edit: |
I'd check with your distro on how to sort out the gstreamer issue - it sounds like you've got all the right packages installed. I'll sure take a look, cheers |
This should definitely be a handled error case though, have you tested GNOME's master branch to confirm the crash? Would be good to file a bugzilla.gnome.org ticket too |
For the reference: In my case it was the GStreamer VAAPI hardware acceleration which wasn't playing nicely. Removing it (packaged We should show some kind of message if GStreamer isn't able to play the track. |
If the gstreamer lib isn't able to play the video it might happen that CurrentTrack is null. Check for null otherwise an NRE might be thrown. Closes #3
I didn't investigate what causes the crash. I tried it with H264 MKV files and the native GStreamer backend.
Suggestion:
Since there are some pretty good cross-platform video players (e.g. VLC) I'd say the video playback feature could be dropped to simplify the codebase a bit.
The text was updated successfully, but these errors were encountered: