Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banshee crashes when playing videos #3

Closed
Carbenium opened this issue Jun 16, 2017 · 5 comments
Closed

Banshee crashes when playing videos #3

Carbenium opened this issue Jun 16, 2017 · 5 comments
Labels

Comments

@Carbenium
Copy link

I didn't investigate what causes the crash. I tried it with H264 MKV files and the native GStreamer backend.

Suggestion:
Since there are some pretty good cross-platform video players (e.g. VLC) I'd say the video playback feature could be dropped to simplify the codebase a bit.

@arfbtwn
Copy link
Owner

arfbtwn commented Jun 17, 2017

Some details on the crash would be handy, every video file or just MKVs?

Personally, since I don't use Banshee for video I agree with your suggestion and I explored doing it a while ago - the changes are quite far-reaching and mean an ABI break for plugins.

The other issue I thought about was our ability to contribute upstream and removing a major feature might hurt that. On balance, for now I think we'll leave it in.

@Carbenium
Copy link
Author

Carbenium commented Jun 17, 2017

Ok, curiosity didn't let to stop me ;)
It's actually GStreamer it self which doesn't like videos. I tried MKVs, MP4s (H264) and AVIs (MPEG-4).
Couldn't get it work on the commandline with playbin and Totem/XPlayer just fail with an unsupported format message.

Installed software versions:
Linux Mint 18.1
GStreamer 1.8.3 (including good, bad, ugly plugins)

Is there any kind of upstream maintainer at the moment?

Edit:
I removed some, in my opinion outdated/unneeded parts in my fork. Just if you want to take a look. https://github.com/Carbenium/banshee/branches

@arfbtwn
Copy link
Owner

arfbtwn commented Jun 17, 2017

I'd check with your distro on how to sort out the gstreamer issue - it sounds like you've got all the right packages installed. I'll sure take a look, cheers

@arfbtwn
Copy link
Owner

arfbtwn commented Jun 17, 2017

This should definitely be a handled error case though, have you tested GNOME's master ​branch to confirm the crash? Would be good to file a bugzilla.gnome.org ticket too

@Carbenium
Copy link
Author

For the reference: In my case it was the GStreamer VAAPI hardware acceleration which wasn't playing nicely. Removing it (packaged gstreamer1.0-vaapi on Ubuntu et al.) fixes a the playack problems.

We should show some kind of message if GStreamer isn't able to play the track.

arfbtwn pushed a commit that referenced this issue Jun 19, 2017
If the gstreamer lib isn't able to play the video it might happen that
CurrentTrack is null. Check for null otherwise an NRE might be thrown.

Closes #3
@arfbtwn arfbtwn added the bug label Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants