ci: Add basic Travis CI support #12

Carbenium · 2017-06-18T18:42:11Z

Travis CI builds the sln using msbuild in Release and Debug configurations

Still disabled projects:

Banshee.Osx - can only built on OS X
Banshee.GStreamerSharp - needs gstreamer-sharp as dependency which isn't that easy to build from official upstream sources
Banshee.Windows - can only be built on Windows
Banshee.Dap.AppleDevice - needs libgpod-cil as dependency which is unmaintained and out of date. IDevices can be synchronized using B.Dap.MassStorage. It might be better to remove this one.
Banshee.Dap.Karma - very old stuff. Probably better to remove, too.
Banshee.UbuntuOneMusicStore - more or less dead

B.YouTube pulls its dependecies on Google.GData.* using NuGet

Ref #4

arfbtwn · 2017-06-19T16:54:49Z

.travis.yml

+  - BUILD_CONFIGURATION=Debug
+
+script:
+  - msbuild /p:Configuration=$BUILD_CONFIGURATION Banshee.sln


hmm, I hadn't thought much about CI when I did the autotools changes in 1e4ea09 (switches for everything, disable all by default)

I think we should stick to using them for building in a CI chain - although it might be more natural to use a solution file here.

I tried master's autotools setup and had to use ./autoregen.sh instead of the generic autoreconf -fvi though and I think if we add part of the above sha1's patch (the M4_DIRS change in configure.ac) then we can get it working, we'll have to add a bunch of --enable/disable switches.

I'd like to build it both ways (Solution and autotools) to ensure compatibility between both build systems. Especially since you can't really use autotools on Windows.

This PR should be just the first step. And since scripting the msbuild part was easier, I did that for starters ;)

Makes sense, both systems should be able to build and we'll be building a full blown package using this configuration rather than a subset - are there any other solution or project file changes needed?

I'm pretty sure autotools works on Windows too though :P

Not that I'm aware of. As you can see here it builds just fine.
For the feature/lite branch we might have to adjust some things, but I haven't had any chance to look at that yet.

I'm pretty sure autotools works on Windows too though :P

Oh well. You never stop learning new things. Although I prefer the msbuild approch for .NET projects.
We might even consider switching to a NuGet based approach to get the dependencies fulfilled. But that needs some more thought.

Yeah I skimmed the build log last week but haven't had a chance to pick it apart - nice to see the successful build.

I've just checked the solution configuration on master branch and it looks like we need to enable some projects for full coverage:

Backends\B.GStreamerSharp; (I think we only build the native one)

Dap\B.AppleDevice;

Dap\B.Karma;

Extensions\B.BooScript;

Extensions\B.SoundMenu; (I'm not on Ubuntu but it should probably build as long as it's still a thing)

Extensions\B.SqlDebugConsole;

Extensions\B.UbuntuOneMusicStore; (I thought UbuntuOne was dead? - think we can ignore this one)

Extensions\B.UPnPClient;

Extensions\B.YouTube.

arfbtwn · 2017-06-19T16:55:59Z

I notice the trusty distro tag, does that mean we can create a ppa (or whatever the current Ubuntu community project is) from our builds?

Carbenium · 2017-06-19T17:10:50Z

Yeah, packaging is something we should think about, too.
In this case the distro tag ensures we build on Ubuntu 14.04. Without it, Travis would default to 12.04, which does not have all dependencies (and frankly is quite old).

nicman23 · 2017-08-21T18:30:53Z

i could probably make the makefiles for a basic deb ...

Carbenium · 2017-09-01T00:53:23Z

@arfbtwn I enabled some more projects to be built.

Do you want the autotools part in this PR? Although I don't really know how to deal with NuGet dependencies using that build system. So some help there would be really appreciated.

arfbtwn · 2017-09-01T20:36:16Z

src/Extensions/Banshee.YouTube/Banshee.YouTube.csproj

+    <PackageReference Include="Google.GData.Client" Version="2.2.0.0" />
+    <PackageReference Include="Google.GData.Extensions" Version="2.2.0.0" />
+    <PackageReference Include="Google.GData.YouTube" Version="2.2.0.0" />
+    <PackageReference Include="Newtonsoft.Json" Version="4.0.5.0" />


what's pulling in this dependency?

All the used Google.GData.* packages.

See https://www.nuget.org/packages/Google.GData.Client/ for example.

arfbtwn · 2017-09-01T20:42:54Z

I wouldn't worry about auto-tools for this one - I guess for NuGet packages we'd want to record the dependencies somewhere in the makefiles and have them restored during the configure phase but having the PackageReference elements seems like the way to go for MSBuild, I'm guessing the YouTube support libraries aren't available as distribution packages anymore?

Carbenium · 2017-09-01T22:46:45Z

I at least couldn't find any distribution packages. Even for gstreamer-sharp I couldn't find anything in the *.deb-world

nicman23 · 2017-09-02T06:48:13Z

werent there an issue to move away from gstreamer-sharp?

arfbtwn · 2017-09-02T09:12:45Z

@nicman23: yeah #6, it's request for comments though; when we raised it we were having some fundamental trouble with the managed engine that @Carbenium was able to patch in #8.

@Carbenium: No worries on the tricky to build/OS dependent stuff, we'll try and take care of some of it in the autotools version so let's remove the commented build script for gstreamer-sharp.

Somewhat unrelated but I had a look at setting up an Ubuntu PPA, might be a solution for getting the tricky dependencies built and packaged so we can install them on the CI build host and target machines in the usual way with apt.

This is looking really good, I'm not sure about the inter-extension dependency from the ubuntu sound menu to the notification area (in order to get the notify-sharp binding stuff) though - perhaps we should pull that internal define out into a small library (ala Mtp) so we can keep those separate? - if you have time to do the refactor and MSBuild changes then I'll follow up with an autotools commit for it.

arfbtwn · 2017-09-02T09:36:26Z

Banshee.sln

@@ -1,649 +1,659 @@
-


Would you mind un-fixing the line endings on this file? - I think the whitespace diff showed just a couple of projects being added to both Debug and Release build configurations.

You may have sane git attributes or core.autocrlf set - I can never figure out which, line endings in git are a bit of black magic - unfortunately the repository at this point doesn't have this commit which should get us all on the same page: b0d226f (it's in feature/fixes)

If you like I'll merge that commit into master and then if you rebase on top of that it should clean up the diff?

Yep, let's do that.

done 👍 #31

Carbenium · 2017-09-02T13:43:12Z

[...] perhaps we should pull that internal define out into a small library (ala Mtp) so we can keep those separate? - if you have time to do the refactor and MSBuild changes then I'll follow up with an autotools commit for it.

I'll see what I can do ;)

arfbtwn · 2017-09-03T09:58:50Z

next time you rebase over this if you make 35d6cd9 a fixup for 89787b9 then I think it'll remove it from the history - looks like that's when the build script appeared :)

Carbenium · 2017-09-03T12:42:38Z

src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea.csproj

@@ -26,6 +26,7 @@
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
    <Optimize>false</Optimize>
    <OutputPath>..\..\..\bin</OutputPath>
+    <DefineConstants>INTERNAL_NOTIFY_SHARP</DefineConstants>


Note to myself: Remove this once the notification lib refactoring is merged.

arfbtwn

Didn't want to bother you while on holiday but I reckon this one's pretty much ready too

Carbenium · 2017-09-11T09:27:49Z

I'm going to take a final look (at least resolve the merge conflict 😉 ) this evening and get back to you on this.

Travis CI build the sln using msbuild in Release and Debug configurations Ref #4

ci: Add libmono-upnp-cil ci: Add nuget restore step using msbuild B.UPnPClient: Adjust hint paths for UPnP libs

Carbenium · 2017-09-12T00:36:22Z

@arfbtwn Alright, we have a green build again. This one is ready from my side.

older xbuild systems can't build

arfbtwn reviewed Jun 19, 2017

View reviewed changes

Carbenium force-pushed the travis branch 7 times, most recently from ee7bb3b to ddb3bc6 Compare September 1, 2017 00:36

Carbenium mentioned this pull request Sep 1, 2017

RFE: Get some CI going #4

Open

4 tasks

arfbtwn reviewed Sep 1, 2017

View reviewed changes

arfbtwn reviewed Sep 2, 2017

View reviewed changes

Carbenium force-pushed the travis branch 2 times, most recently from edfdf43 to 2439fa0 Compare September 2, 2017 17:31

Carbenium force-pushed the travis branch from 2439fa0 to 701fe43 Compare September 3, 2017 12:36

Carbenium commented Sep 3, 2017

View reviewed changes

Carbenium force-pushed the travis branch from 701fe43 to d102ae8 Compare September 3, 2017 12:50

arfbtwn previously approved these changes Sep 11, 2017

View reviewed changes

Carbenium added 2 commits September 12, 2017 01:08

ci: Add basic Travis CI support

5d935dc

Travis CI build the sln using msbuild in Release and Debug configurations Ref #4

B.Youtube: Add Google.GData deps as NuGet packages

3f89cf9

ci: Add libmono-upnp-cil ci: Add nuget restore step using msbuild B.UPnPClient: Adjust hint paths for UPnP libs

Carbenium force-pushed the travis branch from d102ae8 to a6eb884 Compare September 12, 2017 00:11

Carbenium added 3 commits September 12, 2017 01:24

B.SoundMenu: Add some missing references

c60845c

B.YouTube: Use PackageReference for Newtonsoft.Json

5eecc99

build: Disable B.SqlDebugConsole in release builds

122ecc6

Carbenium force-pushed the travis branch from a6eb884 to 122ecc6 Compare September 12, 2017 00:24

arfbtwn mentioned this pull request Sep 15, 2017

Feature/travis #48

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Add basic Travis CI support #12

ci: Add basic Travis CI support #12

Carbenium commented Jun 18, 2017 •

edited

Loading

arfbtwn Jun 19, 2017

Carbenium Jun 19, 2017

arfbtwn Jun 19, 2017 •

edited

Loading

Carbenium Jun 19, 2017

arfbtwn Jun 24, 2017

arfbtwn commented Jun 19, 2017

Carbenium commented Jun 19, 2017

nicman23 commented Aug 21, 2017

Carbenium commented Sep 1, 2017

arfbtwn Sep 1, 2017

Carbenium Sep 1, 2017

arfbtwn commented Sep 1, 2017

Carbenium commented Sep 1, 2017

nicman23 commented Sep 2, 2017

arfbtwn commented Sep 2, 2017 •

edited

Loading

arfbtwn Sep 2, 2017

Carbenium Sep 2, 2017

arfbtwn Sep 2, 2017

Carbenium commented Sep 2, 2017

arfbtwn commented Sep 3, 2017

Carbenium Sep 3, 2017

arfbtwn left a comment

Carbenium commented Sep 11, 2017

Carbenium commented Sep 12, 2017

ci: Add basic Travis CI support #12

Are you sure you want to change the base?

ci: Add basic Travis CI support #12

Conversation

Carbenium commented Jun 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arfbtwn Jun 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arfbtwn commented Jun 19, 2017

Carbenium commented Jun 19, 2017

nicman23 commented Aug 21, 2017

Carbenium commented Sep 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arfbtwn commented Sep 1, 2017

Carbenium commented Sep 1, 2017

nicman23 commented Sep 2, 2017

arfbtwn commented Sep 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Carbenium commented Sep 2, 2017

arfbtwn commented Sep 3, 2017

Choose a reason for hiding this comment

arfbtwn left a comment

Choose a reason for hiding this comment

Carbenium commented Sep 11, 2017

Carbenium commented Sep 12, 2017

Carbenium commented Jun 18, 2017 •

edited

Loading

arfbtwn Jun 19, 2017 •

edited

Loading

arfbtwn commented Sep 2, 2017 •

edited

Loading