Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new single level map input structure #213

Merged
merged 30 commits into from
Mar 29, 2019
Merged

Conversation

gwenchee
Copy link
Collaborator

This PR addresses #212.

@gwenchee gwenchee self-assigned this Mar 12, 2019
@gwenchee gwenchee requested a review from robfairh March 12, 2019 21:19
@pep8speaks
Copy link
Contributor

pep8speaks commented Mar 12, 2019

Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 35:80: E501 line too long (84 > 79 characters)

Line 36:80: E501 line too long (105 > 79 characters)
Line 89:80: E501 line too long (80 > 79 characters)
Line 96:80: E501 line too long (81 > 79 characters)

Line 37:64: W291 trailing whitespace
Line 38:17: E128 continuation line under-indented for visual indent
Line 44:59: W291 trailing whitespace
Line 49:72: W291 trailing whitespace
Line 50:52: E127 continuation line over-indented for visual indent
Line 92:61: W291 trailing whitespace
Line 98:58: W291 trailing whitespace
Line 134:70: W291 trailing whitespace
Line 193:68: W291 trailing whitespace
Line 253:71: W291 trailing whitespace

Comment last updated at 2019-03-28 21:09:21 UTC

@gwenchee
Copy link
Collaborator Author

This works with cyclus/cyclus#1501 version of cyclus

Copy link
Collaborator

@robfairh robfairh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'README.md', 'demand_driven_deploymenty_inst.py', 'solver.py', and 'supply_driven_deployment_inst.py' okay

Then, the files in the folder 'input' reflect the changes in the previous files.

'back_deployment_test.py' was merged in PR #211 already.

Files in folder 'integration_tests' and 'unit_test' reflect changes in the first files of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants