Deploy logic fix #47
Merged
Deploy logic fix #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When this PR is merged, the |
d3ploy/no_inst.py
Outdated
| @@ -184,7 +191,7 @@ def deploy_solver(self, commod, diff): | |||
| Paramters: | |||
| ---------- | |||
| commod: str | |||
| commodity to deploy the prototypes for | |||
| commodity to deploy | |||
There was a problem hiding this comment.
We aren't deploying a commodity here. I agree my original wording is lacking, but I'm not sure this is better.
Maybe "commodity being tracked"?
whatever.sh
Outdated
| @@ -0,0 +1,4 @@ | |||
| rm -rf build | |||
There was a problem hiding this comment.
this file should not be in the git repo. You can add it to the git ignore if you'd like and keep it locally though.
There was a problem hiding this comment.
Oh oops, will remove it.
Deploy logic fix
Deploy logic fix fix
|
@FlanFlanagan reflected your comments! |
|
@FlanFlanagan @jbae11 are we ready to merge this? |
|
Looks good. But can we remove the print statements? |
|
will do! |
|
I have removed the print statements! Merging now. |
This was referenced Oct 1, 2018
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bugs in the #40 PR. And addresses #38 and #23