Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External salt loop only couples on timestep_begin #70

Closed
gridley opened this issue Aug 15, 2018 · 3 comments
Closed

External salt loop only couples on timestep_begin #70

gridley opened this issue Aug 15, 2018 · 3 comments

Comments

@gridley
Copy link
Collaborator

gridley commented Aug 15, 2018

In PrecursorAction.C, the code which controls coupling to the external salt loop should be updated so that inlet and outlet connections between the reactor and salt loop get updated at time appropriate for each solve. In particular, the coupling currently only gets updated now at timestep_begin, since we typically run long adaptive timestep transients to obtain the steady state. A (the one) user outside UIUC (yay!) desires to run InversePowerIteration solves with the external salt loop, so some code to automatically switch postprocessor transfers from timestep_begin to nonlinear iterations should be added. It would go around line 381 of PrecursorAction.C. This is more of a TODO for me, unless someone else wants to get it.

@katyhuff
Copy link
Member

Good luck!

@gridley
Copy link
Collaborator Author

gridley commented Aug 15, 2018

Wait... we can just couple only on nonlinear steps. I'll check. Should be a one-word code fix...

@gridley
Copy link
Collaborator Author

gridley commented Apr 10, 2019

PR #72 fixed this.

@gridley gridley closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants