Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cruft files from master branch #86

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Remove cruft files from master branch #86

merged 1 commit into from
Dec 15, 2021

Conversation

yardasol
Copy link
Contributor

Summary of changes

This PR removes the following cruft files from the master branch:

  • .travis.yml
  • appveyor.yml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@yardasol yardasol added this to the 0.3.0 Release milestone Dec 10, 2021
@yardasol yardasol self-assigned this Dec 10, 2021
@abachma2 abachma2 self-requested a review December 15, 2021 16:50
abachma2
abachma2 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@abachma2 abachma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As long as no functionality has been removed or broken, I approve.

@abachma2 abachma2 merged commit 3c992ec into arfc:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abachma2 abachma2 abachma2 approved these changes

@munkm munkm Awaiting requested review from munkm

@LukeSeifert LukeSeifert Awaiting requested review from LukeSeifert

Assignees

@yardasol yardasol

Labels
Difficulty:1-Beginner Priority:1-Critical Type:Bug
Projects
None yet
Milestone
0.3.0 Release
Development

Successfully merging this pull request may close these issues.

[Bug]: Potential cruft in master?
2 participants
@yardasol @abachma2