Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example and integration test input files to serpent 2 syntax #89

Merged
merged 7 commits into from
Dec 13, 2021
Merged

Update example and integration test input files to serpent 2 syntax #89

merged 7 commits into from
Dec 13, 2021

Conversation

yardasol
Copy link
Contributor

@yardasol yardasol commented Dec 10, 2021 •
edited
Loading

Summary of changes

This PR updates the syntax of cards in the input files for the examples and integration tests for Serpent 2 in SaltProc

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@yardasol yardasol added this to the 0.3.0 Release milestone Dec 10, 2021
@yardasol yardasol marked this pull request as ready for review December 12, 2021 00:18
munkm
munkm approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@munkm munkm merged commit bc8b43c into arfc:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munkm munkm munkm approved these changes

@LukeSeifert LukeSeifert Awaiting requested review from LukeSeifert

@ZoeRichter ZoeRichter Awaiting requested review from ZoeRichter

Assignees
No one assigned
Labels
Comp:Input Difficulty:2-Challenging Priority:1-Critical Type:Bug Type:Style Type:Test
Projects
None yet
Milestone
0.3.0 Release
Development

Successfully merging this pull request may close these issues.

[Bug]: Serpent 1 syntax in integration test input files
2 participants
@yardasol @munkm