fix/wallet_switchStarknetChain RPC Message #1434
Conversation
… BLO-546-wallet-switch-starknet-chain-doesnt-work
dhruvkelawala
force-pushed
the
BLO-546-wallet-switch-starknet-chain-doesnt-work
branch
from
dcded08
to
72e6cb2
Compare
… BLO-546-wallet-switch-starknet-chain-doesnt-work
|
TODO
|
… BLO-546-wallet-switch-starknet-chain-doesnt-work
| data: { actionHash, selectedAccount }, | ||
| } | ||
| } catch (error) { | ||
| console.error(error) |
| ) | ||
| } | ||
|
|
||
| const accountsOnNetwork = await getAccounts( |
There was a problem hiding this comment.
@dhruvkelawala was wondering, does it makes sense to reject if there are no accounts?
couldn't the user create it after switching to the custom network?
There was a problem hiding this comment.
This RPC message will be sent by dApp to ArgentX and not the user. For example, if a dApp wants to use TESTNET2 instead of TESTNET, it will send this message through window object. And when switching the network, the dApp will require an account to connect with. So if the account is not present, dApp cannot connect to anything and even ArgentX won't be able to maintain a state where no account is selected on a network. If a user wants to create an account on network, they can still do it directly from extension. This PR doesn't change that.
…tps://github.com/argentlabs/argent-x into BLO-546-wallet-switch-starknet-chain-doesnt-work
|
@janek26 Waiting for your review on this |
No description provided.