Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hot reload server #1767

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: hot reload server #1767

merged 1 commit into from
Feb 16, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Feb 16, 2023

Issue / feature description

The hot reload server was using debounce from lodash. lodash is banned and lodash-es doesn't work with ts-node atm, leaving hot reload server broken.

Changes

  • have ChatGPT write a debounce function
  • remove lodash / lodash-es dependency

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

@simonheys simonheys marked this pull request as ready for review February 16, 2023 13:21
@github-actions
Copy link

Builds for local testing

@simonheys simonheys merged commit f5e25fe into develop Feb 16, 2023
@simonheys simonheys deleted the fix/hot-reload-server branch February 16, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants