BLO-739 fix: 2fa state transition #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonheys
changed the title
simonheys
force-pushed
the
fix/BLO-739-state-transition
branch
from
53ffadd
to
ec8bca9
Compare
bluecco
approved these changes
Feb 17, 2023
simonheys
force-pushed
the
fix/BLO-739-state-transition
branch
from
ec8bca9
to
c53aa95
Compare
| return "Two-factor account protection" | ||
| }, [isAdding, status]) | ||
|
|
||
| const shieldIsLoading = liveAccountGuardianState.status === "PENDING" |
There was a problem hiding this comment.
this should be in a usememo no ?
There was a problem hiding this comment.
I believe is okay if it's not a complex / slow operation, memoizing and checking the memo may well make it slower. More about 'expensive' calculations here: https://beta.reactjs.org/learn/you-might-not-need-an-effect#updating-state-based-on-props-or-state
| } | ||
| } | ||
| if (status === "PENDING") { | ||
| return { |
There was a problem hiding this comment.
mb instead of having ternaries everywhere we can have just one if ?
diegodelrieu
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Fixes an issue where the 'live' state of 2FA on account was not in sync with on-chain state and would show momentarily in the wrong state
Changes
Checklist