feat: discover localhost accounts #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluecco
reviewed
Feb 16, 2023
| @@ -301,8 +302,9 @@ export class Wallet { | |||
| }, | |||
| ) | |||
|
|
|||
| await Promise.allSettled(promises) | |||
There was a problem hiding this comment.
is there a specific reason to move this from the try {} catch block?
canlopes
approved these changes
Feb 16, 2023
| @@ -1,7 +1,7 @@ | |||
| import path from "path" | |||
|
|
|||
| import chokidar from "chokidar" | |||
| import { debounce } from "lodash-es" | |||
| import debounce from "lodash/debounce" | |||
There was a problem hiding this comment.
I thought this has been resolved already ?
There was a problem hiding this comment.
@diegodelrieu branch needs to be merged with develop, that's probably why
diegodelrieu
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
We should allow for devnet account discovery
Changes
Checklist
Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.
Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.