[BLO-806] Add static analysis with Sonarqube to Argent-X #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
diegodelrieu
force-pushed
the
BLO-806
branch
from
1168a03
to
e31088c
Compare
diegodelrieu
changed the title
|
would love @gergold 's feedback on this |
1 similar comment
gergold
approved these changes
Feb 27, 2023
janek26
approved these changes
Feb 27, 2023
diegodelrieu
force-pushed
the
BLO-806
branch
from
3496c67
to
b007ad5
Compare
canlopes
reviewed
Feb 27, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Add static code analysis to Argent x, quite a lot to discuss hereBasically the whole point is to make sure the code quality is checked at every PR and to allow us to enforce best practices whenever new code is shipped.
The sonarqube dashbaord is available here : https://sonarcloud.io/project/overview?id=argentlabs_argent-x
In sonarqube there's a concept of quality gates which are a set of rules that define what NEW code should go through or not. (emphasis on new to make sure we can start working on it and having the CI green from the beginning). For now they seem a little bit ambitious but we can review them later together and decide what ambitions we have there. Here is the current quality gates (these are company wide expectations - not specific to Argent x)
This particular PR fails the quality gates because of PRs that have been merged since then.
Changes
test:cito collect test coverage when running tests in CI . We only collect coverage for UT for now, later we can add coverage for e2e tests but I think it can be a bit misleading.