Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-859 fix: 2fa checks #1868

Merged
merged 4 commits into from
Mar 7, 2023
Merged

BLO-859 fix: 2fa checks #1868

merged 4 commits into from
Mar 7, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Mar 2, 2023 •
edited
Loading

Issue / feature description

Missing specific expiry check for remove guardian tx and email expiry

Changes

  • additional check for remove guardian tx
  • change to use cancelEscape

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Builds for local testing

@simonheys simonheys changed the base branch from develop to feat/BLO-838-2fa-expiry March 2, 2023 11:03
@simonheys simonheys marked this pull request as ready for review March 2, 2023 11:12
@simonheys simonheys marked this pull request as draft March 2, 2023 11:13
@simonheys simonheys changed the base branch from feat/BLO-838-2fa-expiry to develop March 2, 2023 12:59
@simonheys simonheys marked this pull request as ready for review March 2, 2023 15:24
@simonheys simonheys added the 2fa label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Builds for local testing

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Builds for local testing

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.3% 2.3% Duplication

@simonheys simonheys merged commit 9cdf7e2 into develop Mar 7, 2023
@simonheys simonheys deleted the fix/BLO-859-2fa-checks branch March 7, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluecco bluecco bluecco approved these changes

@dhruvkelawala dhruvkelawala dhruvkelawala approved these changes

@diegodelrieu diegodelrieu Awaiting requested review from diegodelrieu

Assignees
No one assigned
Labels
2fa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonheys @bluecco @dhruvkelawala