UI: New rule metrics layout #861

leiyre · 2021-12-30T10:35:21Z

Closes #860
Closes #867

dvsrepo · 2021-12-30T22:33:56Z

Looks good!

Some comments:

There's a resize of the rule labels box when saving a rule (it becomes smaller). We should keep the size of the box as stable as possible. See gif below and next comment.
If possible it would be great to reduce the "refresh" effect on the rule labels and rule metrics boxes. Ideally those should not be refreshed completely (only the numbers, the labels, etc.) and should keep a stable, fixed size. The record list below of course needs to be refreshed. I don't know if its a lot of work, if it's not too much I would tackle this for the release. See gif below.
In the label definition box, is the number of records available to show it before selecting a label ( Records 0/11.100
)? If can be known before selecting a label we should show it, otherwise is fine.

Amelie-V · 2021-12-30T22:35:07Z

Define rule

Blue block: Global metrics should be bolder (check UI)
Blue blocks: In both view (define rules and rules list) add a bit more margin (30 instead of 20)
Define rule area: query name should be larger (like in the last version, (same size as "New Query")
Save rule button should be fixed at the bottom (just like the info when rules is already saved)
The goal is to fit 3 lines of labels and then show : "+ X labels" (just in case, i cant test it)
Spaces between search box and the 2 blocks should be 10px (just like between the two blocks)

dvsrepo · 2021-12-31T12:51:25Z

@leiyre I've reviewed all raised points and it's looking good!!

Testing I have found these two issues:

Avg. precision and total incorrect/correct suddenly become 0 both in rule definition and rule management views (see gif)
When a rule is saved, you are able to change the label but clicking on save label has no effect.

leiyre · 2022-01-03T09:37:58Z

@Amelie-V

The goal is to fit 3 lines of labels and then show : "+ X labels" (just in case, i cant test it)

The width is dynamic, it's better to define a fixed number of elements. By default is a max of 10

Spaces between search box and the 2 blocks should be 10px (just like between the two blocks)

The spacing is common to all views, the bottom margin of the seacrhbox is 14px, if we change it to 10px it will affect all views. it's ok?

frontend/components/text-classifier/labeling-rules/RuleDefinition.vue

frascuchon · 2022-01-03T10:45:51Z

Comment from my part:

The message "The query is already saved as a rule" when a rule is already stored it could be confusing if we only change the label:

In both cases the query remains the same. As suggestion (but sure I'm not an expert) keeping the save rule button enabled/disabled depending on the rule was already created. Or maybe change the action name (Create Rule/ Save rule)

@Amelie-V ?

dvsrepo · 2022-01-03T12:15:02Z

I agree. The message is confusing and the interaction too.

In my opinion:

Improve the message to: This query with this label are already saved as rule.
Showing disabled button is a good idea, but I would keep the message otherwise it will still be confusing.
The message after saving the rule shouldnt be the message above, but: The rule has been saved.

frascuchon · 2022-01-03T13:06:52Z

The message after saving the rule shouldnt be the message above, but: The rule has been saved.

We have already a global mechanism to notify completed actions. I prefer show this message as a toast notification.

frascuchon · 2022-01-03T13:23:56Z

It could be nice to include some color schema to highlight the best rule metrics. The greater value for precision, the better, or the lower value for incorrect records, the better too. This could help to users to analyze rule

frascuchon · 2022-01-03T13:50:22Z

Affected records count (Records: ...) should be shown only if we have label info. Otherwise, it's quite confusing:

The same could be applied to coverage and annotated coverage (Giving 0% of coverage while rule query returns results is confusing)

frontend/components/text-classifier/labeling-rules/RulesManagement.vue

frontend/components/text-classifier/labeling-rules/RulesMetrics.vue

leiyre · 2022-01-04T10:36:40Z

fix #867

frascuchon

Closing this PR and all pending tasks must be transcribed as separate issues

* 'master' of https://github.com/recognai/rubrix: Docs: Updates Flair zeroshot tutorial (#887) removing wrong video (#885) Update readme (#883) fix(UI) Metrics value by default if no metric (#875) feat(metrics): add token level metrics for token classification from client (#849) UI: New rule metrics layout (#861) chore: expose load_rules from base module (#866)

* remove old rule metrics * remove old overall metrics * new metrics component * restructure metrics * styles * button position * metrics min height * metrics loading placeholder * fix metric item height * show loading only in records area when refresh * fix padding and font-size * fix update total metrics * fix lint * show all non-reactive buttons * fix styles * rules props * text style * change copy * labels as array * prevent empty rules * fix empty search for data filter * nw rule empty query component * refresh only general metrics when updating the rule * overall metrics transition

LeireA added 5 commits December 30, 2021 11:32

remove old rule metrics

ac33697

remove old overall metrics

79dedb9

new metrics component

45b9dbd

restructure metrics

f795ee0

styles

2b2c893

leiyre changed the title ~~UI/new rule metrics~~ UI: New rule metrics layout Dec 30, 2021

LeireA added 6 commits December 31, 2021 11:17

button position

dbd0eee

metrics min height

8d2072f

metrics loading placeholder

f590a4d

fix metric item height

c9abee3

show loading only in records area when refresh

f8d803d

fix padding and font-size

6f7a626

LeireA added 4 commits January 3, 2022 10:04

fix update total metrics

ea56412

fix lint

c88c698

show all non-reactive buttons

5a865da

fix styles

edbb469

leiyre closed this Jan 3, 2022

leiyre reopened this Jan 3, 2022

frascuchon reviewed Jan 3, 2022

View reviewed changes

frontend/components/text-classifier/labeling-rules/RuleDefinition.vue Outdated Show resolved Hide resolved

frontend/components/text-classifier/labeling-rules/RuleDefinition.vue Show resolved Hide resolved

LeireA added 4 commits January 3, 2022 13:29

rules props

f92c6e4

text style

e8709ea

change copy

d790f00

labels as array

a1e0a62

frascuchon reviewed Jan 3, 2022

View reviewed changes

frontend/components/text-classifier/labeling-rules/RulesManagement.vue Show resolved Hide resolved

frontend/components/text-classifier/labeling-rules/RulesMetrics.vue Show resolved Hide resolved

LeireA added 5 commits January 3, 2022 15:04

prevent empty rules

5fa794d

fix empty search for data filter

ba5624d

nw rule empty query component

0b5cd1a

refresh only general metrics when updating the rule

584c36d

overall metrics transition

f62f80c

frascuchon self-requested a review January 4, 2022 10:41

frascuchon approved these changes Jan 4, 2022

View reviewed changes

frascuchon merged commit d6a32dc into master Jan 4, 2022

frascuchon deleted the ui/new_rule_metrics branch January 4, 2022 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: New rule metrics layout #861

UI: New rule metrics layout #861

leiyre commented Dec 30, 2021 •

edited by frascuchon

Loading

dvsrepo commented Dec 30, 2021 •

edited

Loading

Amelie-V commented Dec 30, 2021 •

edited by leiyre

Loading

dvsrepo commented Dec 31, 2021 •

edited by leiyre

Loading

leiyre commented Jan 3, 2022 •

edited

Loading

frascuchon commented Jan 3, 2022 •

edited

Loading

dvsrepo commented Jan 3, 2022

frascuchon commented Jan 3, 2022

frascuchon commented Jan 3, 2022

frascuchon commented Jan 3, 2022 •

edited

Loading

leiyre commented Jan 4, 2022

frascuchon left a comment

UI: New rule metrics layout #861

UI: New rule metrics layout #861

Conversation

leiyre commented Dec 30, 2021 • edited by frascuchon Loading

dvsrepo commented Dec 30, 2021 • edited Loading

Amelie-V commented Dec 30, 2021 • edited by leiyre Loading

Define rule

dvsrepo commented Dec 31, 2021 • edited by leiyre Loading

leiyre commented Jan 3, 2022 • edited Loading

frascuchon commented Jan 3, 2022 • edited Loading

dvsrepo commented Jan 3, 2022

frascuchon commented Jan 3, 2022

frascuchon commented Jan 3, 2022

frascuchon commented Jan 3, 2022 • edited Loading

leiyre commented Jan 4, 2022

frascuchon left a comment

Choose a reason for hiding this comment

leiyre commented Dec 30, 2021 •

edited by frascuchon

Loading

dvsrepo commented Dec 30, 2021 •

edited

Loading

Amelie-V commented Dec 30, 2021 •

edited by leiyre

Loading

dvsrepo commented Dec 31, 2021 •

edited by leiyre

Loading

leiyre commented Jan 3, 2022 •

edited

Loading

frascuchon commented Jan 3, 2022 •

edited

Loading

frascuchon commented Jan 3, 2022 •

edited

Loading