Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Fix OpenSearch memory problems #2019

Merged

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Dec 9, 2022

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 89.48% // Head: 89.68% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (423fa02) compared to base (2d66715).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feature/similarity-vector-search    #2019      +/-   ##
====================================================================
+ Coverage                             89.48%   89.68%   +0.20%     
====================================================================
  Files                                   158      158              
  Lines                                  7871     7852      -19     
====================================================================
- Hits                                   7043     7042       -1     
+ Misses                                  828      810      -18     
Flag Coverage Δ
pytest 89.68% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../server/daos/backend/client_adapters/opensearch.py 91.80% <ø> (+5.73%) ⬆️
src/argilla/server/daos/backend/generic_elastic.py 88.41% <ø> (ø)
.../argilla/server/daos/backend/mappings/text2text.py 100.00% <ø> (ø)
src/argilla/server/services/metrics/models.py 81.25% <ø> (ø)
.../argilla/server/services/tasks/text2text/models.py 97.36% <ø> (ø)
...server/services/tasks/text_classification/model.py 99.32% <ø> (ø)
...erver/services/tasks/token_classification/model.py 98.97% <ø> (ø)
src/argilla/server/settings.py 76.66% <ø> (-0.39%) ⬇️
...lla/server/daos/backend/client_adapters/factory.py 92.85% <100.00%> (-3.58%) ⬇️
...rc/argilla/server/daos/backend/mappings/helpers.py 97.87% <100.00%> (-0.59%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit 5cd2fee into feature/similarity-vector-search Dec 15, 2022
@frascuchon frascuchon deleted the perf/opensearch-memory-leak branch December 15, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant