feat: include OAuth2 authentication flow #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…b.com:argilla-io/argilla into refactor/moving-security-routes-to-api-module
for more information, see https://pre-commit.ci
…b.com:argilla-io/argilla into refactor/moving-security-routes-to-api-module
for more information, see https://pre-commit.ci
…b.com:argilla-io/argilla into refactor/moving-security-routes-to-api-module
Co-authored-by: José Francisco Calvo <jose@argilla.io>
dosubot
bot
added
size:XL
for more information, see https://pre-commit.ci
dosubot
bot
added
size:XXL
…rgilla-io/argilla into feat/include-oauth-authentication-flow
dosubot
bot
added
size:XL
frascuchon
changed the title
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4546-ki24f765kq-no.a.run.app |
jfcalvo
requested changes
Jan 30, 2024
| return provider.authorization_redirect(request) | ||
|
|
||
|
|
||
| @router.get("/providers/{provider}/access-token") |
There was a problem hiding this comment.
Should we add response_model=Token here?
for more information, see https://pre-commit.ci
…rgilla-io/argilla into feat/include-oauth-authentication-flow
jfcalvo
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OAuth2 integration flow
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
Running locally
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)