Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update send_album_art.py #32

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

secludedhusky
Copy link
Contributor

After extensive debugging with the Socket PDUs for HD Album Art and Title/Artist, I have determined that around the 10-12 hour mark of running the program, it outputs the following error for each Socket PDU:

socket pdu :error: system:24

After doing some research on this error, I have found out that the way the current send_album_art script is coded that it doesn't properly close and shutdown the connection after album art is sent, meaning that after a certain amount of time running the script, it causes a buffer Receive Queue on the TCP sockets.

image

This Recv-Q value means that the TCP socket is queuing any additional data that is sent to it after the buffer overflows. Since GNURadio doesn't adequately handle the closing and shutdown of connections through Socket PDU blocks, setting the python script to handle the shutdown itself patches this issue.

@secludedhusky secludedhusky mentioned this pull request Aug 10, 2023
@argilo
Copy link
Owner

argilo commented Nov 3, 2023

Thanks. I wasn't able to reproduce the problem myself, but the change looks reasonable. I made one simplification (removing an import) and will now merge.

@argilo argilo merged commit 7f66e6e into argilo:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants