Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipefail #111

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Fix pipefail #111

merged 3 commits into from
Jul 11, 2023

Conversation

TApplencourt
Copy link
Collaborator

@TApplencourt TApplencourt commented Jul 11, 2023 •
edited
Loading

So because of pipefail the error of broken pipe (which can appear when doing something like foo | head -1) will make all the programs stop silently.

This fix this by using || true

(Kind of important, as iprof -r is currently broken :( )

@TApplencourt TApplencourt requested a review from Kerilk July 11, 2023 16:37
Thomas Applencourt and others added 2 commits July 11, 2023 16:38
Kerilk
Kerilk approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@Kerilk Kerilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Kerilk Kerilk merged commit 5f56cdd into master Jul 11, 2023
@TApplencourt TApplencourt deleted the fix_pipefail branch July 11, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerilk Kerilk Kerilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TApplencourt @Kerilk