Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started docs #634

Merged
merged 5 commits into from
May 25, 2023
Merged

Getting started docs #634

merged 5 commits into from
May 25, 2023

Conversation

elliotgunton
Copy link
Collaborator

@elliotgunton elliotgunton commented May 23, 2023

Pull Request Checklist

Description of PR

See #627. This PR gets users off the ground. Future PRs to cover features like DAGs, Artifacts etc

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #634 (a1f00d4) into main (36aeef4) will not change coverage.
The diff coverage is n/a.

❗ Current head a1f00d4 differs from pull request most recent head 72764ae. Consider uploading reports for the commit 72764ae to get more accurate results

@@          Coverage Diff          @@
##            main    #634   +/-   ##
=====================================
  Coverage   72.6%   72.6%           
=====================================
  Files         42      42           
  Lines       2920    2920           
  Branches     569     569           
=====================================
  Hits        2122    2122           
  Misses       646     646           
  Partials     152     152           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

flaviuvadan
flaviuvadan previously approved these changes May 23, 2023
Copy link
Collaborator

@flaviuvadan flaviuvadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an awesome start 🚀

@flaviuvadan flaviuvadan added semver:patch A change requiring a patch version bump type:documentation A documentation update labels May 23, 2023
* Add existing installation guide

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@flaviuvadan flaviuvadan dismissed their stale review May 24, 2023 14:01

Approved prematurely, going to review again :)

* Also formatting and small fixes

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@elliotgunton elliotgunton changed the title WIP Getting started docs Getting started docs May 24, 2023
@elliotgunton elliotgunton marked this pull request as ready for review May 24, 2023 16:37
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Copy link
Collaborator

@flaviuvadan flaviuvadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks brilliant @elliotgunton! 🎖️

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@elliotgunton elliotgunton enabled auto-merge (squash) May 25, 2023 14:03
@elliotgunton elliotgunton merged commit 373c8f2 into argoproj-labs:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Getting Started" docs
3 participants