[#636] Add special case handling of cron workflow status #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviuvadan
added
semver:patch
4 tasks
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
flaviuvadan
force-pushed
the
fv/fix-cron-wf-return
branch
from
e47312f
to
255a9f2
Compare
Codecov Report
@@ Coverage Diff @@
## main #637 +/- ##
=====================================
Coverage 72.7% 72.7%
=====================================
Files 42 42
Lines 2937 2937
Branches 572 572
=====================================
Hits 2137 2137
Misses 648 648
Partials 152 152 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
flaviuvadan
changed the title
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
|
Seems I messed up the DCO check, sorry 😓 github UI wouldn't let me change the email to sign off 🙄 |
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, the Argo server does not return cron workflow statuses when a users' cron workflow does not execute immediately post submission. So,
Nones are returned for the independent fields of the cron workflow status. While the status is indeed optional, the fields are not! This PR adds a special case for handling this in the service. I am not sure whether this is a feature or a bug upstream in Argo Workflows.CC: @iameskild I was able to run your example using the fix in this PR!