Add V4 examples and make on_exit handlers take Templates not just str
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
# Conflicts: # src/hera/workflows/_mixins.py
* Fixes comparison with map-reduce across versions in CI Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
flaviuvadan
added
type:enhancement
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
=======================================
+ Coverage 73.0% 74.4% +1.4%
=======================================
Files 43 43
Lines 3029 3053 +24
Branches 580 585 +5
=======================================
+ Hits 2212 2274 +62
+ Misses 657 615 -42
- Partials 160 164 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sambhav
approved these changes
May 28, 2023
<!-- Thank you for submitting a PR to Hera! 🚀 --> **Pull Request Checklist** - [ ] Fixes #<!--issue number goes here--> - [ ] Tests added - [x] Documentation/examples added - [ ] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title <!-- Also remember to sign off commits or the DCO check will fail on your PR! --> **Description of PR** <!-- If not linked to an issue, please describe your changes here --> Hera does not have all the upstream examples. This PR adds more <!-- Piece of cake! ✨🍰✨ --> --------- Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com> Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, the Hera v4 examples are mostly missing. This PR adds numerous examples from V4 and also fixes a few tiny bugs that were identified: