Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts walk through #659

Merged
merged 8 commits into from
May 31, 2023

Conversation

elliotgunton
Copy link
Collaborator

@elliotgunton elliotgunton commented May 30, 2023

Pull Request Checklist

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #659 (e3b2be2) into main (b422547) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #659   +/-   ##
=====================================
  Coverage   74.0%   74.0%           
=====================================
  Files         43      43           
  Lines       3019    3019           
  Branches     575     575           
=====================================
  Hits        2237    2237           
  Misses       616     616           
  Partials     166     166           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@elliotgunton elliotgunton changed the title [WIP] Artifacts walk through Artifacts walk through May 31, 2023
@elliotgunton elliotgunton marked this pull request as ready for review May 31, 2023 09:24
@elliotgunton elliotgunton added semver:patch A change requiring a patch version bump type:documentation A documentation update labels May 31, 2023
* Can't use "wb" when writing strings, must be "w" only

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@elliotgunton elliotgunton enabled auto-merge (squash) May 31, 2023 11:14
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
@elliotgunton elliotgunton enabled auto-merge (squash) May 31, 2023 11:21
@elliotgunton elliotgunton merged commit aa1fee4 into argoproj-labs:main May 31, 2023
@elliotgunton elliotgunton deleted the walkthrough/artifacts branch May 31, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants