-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loops walkthrough (with_item/with_param, fanout/fanin) #660
Conversation
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think things like "{{item.name}}"
are set automatically for Task
arguments. Should we expose that to Step
as well?
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
e317e29
to
9332d21
Compare
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
=======================================
- Coverage 74.6% 74.3% -0.3%
=======================================
Files 43 43
Lines 3017 3017
Branches 575 575
=======================================
- Hits 2252 2244 -8
- Misses 591 602 +11
+ Partials 174 171 -3 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@elliotgunton can confirm these are set automatically for tasks based on arguments inference. So, |
@flaviuvadan 100% agree - we made this change in the source-kwargs branch here https://github.com/argoproj-labs/hera/blob/d0f117f82616c00592346932fcfcc7c9e0d57677/src/hera/workflows/_mixins.py#LL468C27-L468C27, think it's fine to move it out of the Task |
**Description of PR** _Copied from [comment](#660 (comment) >>I think things like "{{item.name}}" are set automatically for Task arguments. Should we expose that to Step as well? >@elliotgunton can confirm these are set automatically for tasks based on arguments inference. So, Task invocation does not need the arguments field when with_param is passed, or with_item, but Step does for now. We should add the same logic to Step as well: https://github.com/argoproj-labs/hera/blob/main/src/hera/workflows/_mixins.py#L469 Motivation here is to not confuse users with these differences of "sometimes I can set a thing on Task but not on Step" --------- Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
00dc608
to
09883a2
Compare
Pull Request Checklist
Tests addedDocs only