Add CronWorkflow.update, add unit tests #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameskild
requested review from
flaviuvadan,
sambhav and
elliotgunton
as code owners
elliotgunton
approved these changes
Jun 15, 2023
|
Hey @iameskild - you'll need to rebase and push with signoff to pass the DCO check. You can run these to fix it: |
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
=====================================
Coverage 76.1% 76.2%
=====================================
Files 45 45
Lines 3088 3105 +17
Branches 584 584
=====================================
+ Hits 2352 2368 +16
- Misses 566 567 +1
Partials 170 170
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: iameskild <eskild.eriksen122@gmail.com>
iameskild
force-pushed
the
update_cronworkflow
branch
from
8ade723
to
163fe27
Compare
|
Thanks @elliotgunton! Added my sign-off to the commit :) |
elliotgunton
added
semver:patch
elliotgunton
added
semver:minor
4 tasks
elliotgunton
pushed a commit
that referenced
this pull request
Jun 16, 2023
**Pull Request Checklist** - [x] Fixes #<!--issue number goes here--> - [x] Tests added - [ ] Documentation/examples added - [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title **Description of PR** In my previous PR #681, I'm using the wrong parameter when calling `UpdateCronWorkflowRequest`; it should've been `cron_workflow` and not `template`. To validate that this change is needed, I used this simple example. Without the fix from this PR, you will likely receive the following error message: ``` hera.exceptions.InternalServerError: Server returned status code 500 with message: `runtime error: invalid memory address or nil pointer dereference` ``` <details> ```py import time from hera.workflows import CronWorkflow, Container # authenticate w Argo Server global_config = authenticate() with CronWorkflow( name="my-cw", namespace=global_config.namespace, schedule="*/1 * * * *", entrypoint="main", ) as cw: cmd_args = ["-c", "echo 'hello world'"] main = Container( name="main", command=["/bin/sh"], args=cmd_args, ) pass cw.create() time.sleep(10) with CronWorkflow( name="my-cw", namespace=global_config.namespace, schedule="2 * * * *", # new schedule entrypoint="main", ) as ncw: cmd_args = ["-c", "echo 'hello world'"] main = Container( name="main", command=["/bin/sh"], args=cmd_args, ) ncw.update() ``` </details> Signed-off-by: iameskild <eskild.eriksen122@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Include methods (
updateandget) to theCronWorkflowobject - to matchWorkflowTemplate.cc @elliotgunton