Add Content-Type header to PUT and POST requests #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aleksatr <aleksatr@gmail.com>
aleksatr
requested review from
flaviuvadan,
sambhav and
elliotgunton
as code owners
Signed-off-by: aleksatr <aleksatr@gmail.com>
flaviuvadan
added
semver:patch
flaviuvadan
approved these changes
Jul 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
=====================================
Coverage 77.4% 77.4%
=====================================
Files 45 45
Lines 3325 3325
Branches 634 634
=====================================
Hits 2575 2575
Misses 575 575
Partials 175 175 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sambhav
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, outgoing PUT and POST requests don't have a "Content-Type" header ("application/json" in all cases here).
Argo doesn't seem to mind that, but when interfacing with other HTTP servers (or proxies) this may be a requirement for a JSON payload.
This PR adds "Content-Type" header to all PUT and POST requests.