Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): ensure ServerName and PortForwardNamespace are set on ClientOptions when port forwarding #378

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

onematchfox
Copy link
Collaborator

Configuring the provider with port forwarding is currently broken in v6.1.0 due to changes introduced in argoproj/argo-cd#14605. That PR introduced the requirement to set both ServerName and PortForwardNamespace when making use of port forwarding.

At present, v6.1.0 will fail with the following error as we are not setting these values.

╷
│ Error: failed to create new API client
│ 
│   with argocd_repository.this,
│   on repository.tf line 1, in resource "argocd_repository" "this":
│    1: resource "argocd_repository" "this" {
│ 
│ cannot find pod with selector: [app.kubernetes.io/name=] - use the --{component}-name flag in this command or set the environmental variable (Refer to
│ https://argo-cd.readthedocs.io/en/stable/user-guide/environment-variables), to change the Argo CD component name in the CLI
╵

This PR ensures that we set both of these values.

Copy link
Collaborator

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@HuaweiDonor
Copy link

When new version will upload ? Will it have new tag or save 6.1.0 ?

@onematchfox
Copy link
Collaborator Author

When new version will upload ?

Once this PR has been reviewed and merged and I have time to kick off a release build.

Will it have new tag or save 6.1.0 ?

It will be a new version - 6.1.1

@HuaweiDonor
Copy link

Thanks !

@onematchfox
Copy link
Collaborator Author

@oboukili Any chance you can take a quick look at this? Unfortunately this is affecting quite a few people that want to upgrade to 6.1.0.

@onematchfox
Copy link
Collaborator Author

Closes #382

@oboukili oboukili merged commit cbea711 into argoproj-labs:master Mar 27, 2024
6 checks passed
@onematchfox onematchfox deleted the fix/port-forwarding branch March 27, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants