fix(provider): ensure ServerName
and PortForwardNamespace
are set on ClientOptions
when port forwarding
#378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring the provider with port forwarding is currently broken in
v6.1.0
due to changes introduced in argoproj/argo-cd#14605. That PR introduced the requirement to set bothServerName
andPortForwardNamespace
when making use of port forwarding.At present,
v6.1.0
will fail with the following error as we are not setting these values.This PR ensures that we set both of these values.