Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI admin dashboard doesn't support redis-compression #13055

Closed
3 tasks done
aborilov opened this issue Mar 30, 2023 · 2 comments · Fixed by #13056
Closed
3 tasks done

CLI admin dashboard doesn't support redis-compression #13055

aborilov opened this issue Mar 30, 2023 · 2 comments · Fixed by #13056
Assignees
@aborilov
Labels
bug Something isn't working

Comments

@aborilov
Copy link
Contributor

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

When redis-compression is used by application-controller there is no way to make argocd admin dashboard work with that cache

To Reproduce

  • Enable redis-compression for application controller using env REDIS_COMPRESSION with value gzip
  • run argocd admin dashboard, select application and follow to the pods or network view
  • information won't be available on those pages

Expected behavior

UI should be able to display application information without problems.

Screenshots

image

Version

argocd: v2.6.7+5bcd846.dirty
  BuildDate: 2023-03-23T17:23:10Z
  GitCommit: 5bcd846fa16e4b19d8f477de7da50ec0aef320e5
  GitTreeState: dirty
  GoVersion: go1.20.2
  Compiler: gc
  Platform: darwin/arm64

Logs

ERRO[0007] finished unary call with code Unknown         error="error getting cached app resource tree: cache: key is missing" grpc.code=Unknown grpc.method=ResourceTree grpc.service=application.ApplicationService grpc.start_time="2023-03-30T21:43:16+08:00" grpc.time_ms=571.788 span.kind=server system=grpc
@aborilov aborilov added the bug Something isn't working label Mar 30, 2023
@crenshaw-dev
Copy link
Collaborator

@aborilov how did you enable the flag? With redis.compression in argocd-cmd-params-cm, or directly on one or more StatefulSets/Deployments?

@aborilov
Copy link
Contributor Author

directly in application-controller deployment

@aborilov aborilov mentioned this issue Mar 30, 2023
Merged
12 tasks
crenshaw-dev added a commit that referenced this issue Apr 4, 2023
@aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
381fed5 
…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Apr 4, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Apr 4, 2023
@aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
12dd336 
…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Apr 4, 2023
@aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
36a3a07 
…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Apr 4, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Apr 4, 2023
@aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
5418e99 
…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Apr 4, 2023
Merged
alexmt pushed a commit that referenced this issue Apr 6, 2023
@gcp-cherry-pick-bot @aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
77fdcb7 
…nd (#13055) (#13056) (#13116)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.



* update dashboard docs for --redis-compress flag



* add support for REDIS_COMRESSION env in cli admin dashboard



* update flag description




* update dashboard docs



---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
alexmt pushed a commit that referenced this issue Apr 6, 2023
@gcp-cherry-pick-bot @aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
61d0ef7 
…nd (#13055) (#13056) (#13115)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.



* update dashboard docs for --redis-compress flag



* add support for REDIS_COMRESSION env in cli admin dashboard



* update flag description




* update dashboard docs



---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
alexmt pushed a commit that referenced this issue Apr 6, 2023
@gcp-cherry-pick-bot @aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
52de54a 
…nd (#13055) (#13056) (#13114)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.



* update dashboard docs for --redis-compress flag



* add support for REDIS_COMRESSION env in cli admin dashboard



* update flag description




* update dashboard docs



---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this issue Jul 24, 2023
@gcp-cherry-pick-bot @aborilov
@crenshaw-dev @schakrad
fix(cli): add redis-compress flag to argocd admin dashboard comma…
cca92e5 
…nd (argoproj#13055) (argoproj#13056) (argoproj#13114)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

* update dashboard docs for --redis-compress flag

* add support for REDIS_COMRESSION env in cli admin dashboard

* update flag description

* update dashboard docs

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
@aborilov @crenshaw-dev
fix(cli): add redis-compress flag to argocd admin dashboard comma…
25882d1 
…nd (argoproj#13055) (argoproj#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborilov aborilov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): add redis-compress flag to argocd admin dashboard command (#13055) aborilov/argo-cd
2 participants
@crenshaw-dev @aborilov