Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add redis-compress flag to argocd admin dashboard command (#13055) (cherry-pick #13056) #13116

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(cli): add redis-compress flag to argocd admin dashboard command (#13055) (#13056)

  • add redis-compress flag to argocd admin dashboard command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov aborilov@gmail.com

  • update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov aborilov@gmail.com

  • add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov aborilov@gmail.com

  • update flag description

Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Pavel aborilov@gmail.com

  • update dashboard docs

Signed-off-by: Pavel Aborilov aborilov@gmail.com


Signed-off-by: Pavel Aborilov aborilov@gmail.com
Signed-off-by: Pavel aborilov@gmail.com
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (ee174fa) 47.75% compared to head (5418e99) 47.73%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.5   #13116      +/-   ##
===============================================
- Coverage        47.75%   47.73%   -0.02%     
===============================================
  Files              239      239              
  Lines            39724    39728       +4     
===============================================
- Hits             18970    18966       -4     
- Misses           18804    18811       +7     
- Partials          1950     1951       +1     
Impacted Files Coverage Δ
cmd/argocd/commands/admin/dashboard.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexmt alexmt merged commit 77fdcb7 into release-2.5 Apr 6, 2023
17 of 19 checks passed
@alexmt alexmt deleted the cherry-pick-760749-release-2.5 branch April 6, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants